INN commit: trunk/expire (makehistory.c)

INN Commit rra at isc.org
Sat Sep 25 21:37:18 UTC 2010


    Date: Saturday, September 25, 2010 @ 14:37:17
  Author: iulius
Revision: 9116

No impact because the NeedHeadername member is not used in this case.
Yet, better put it right.

Modified:
  trunk/expire/makehistory.c

---------------+
 makehistory.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Modified: makehistory.c
===================================================================
--- makehistory.c	2010-09-25 21:32:07 UTC (rev 9115)
+++ makehistory.c	2010-09-25 21:37:17 UTC (rev 9116)
@@ -487,6 +487,8 @@
         Missfieldsize++;
     if (Msgidp == (ARTOVERFIELD *)NULL)
 	Missfieldsize++;
+    /* The fields in Missfields are not used in the overview (because they were not
+     * set before), so the values do not matter much (especially for NeedHeadername). */
     if (Missfieldsize > 0) {
 	Missfields = xmalloc(Missfieldsize * sizeof(ARTOVERFIELD));
         fp = Missfields;
@@ -509,7 +511,7 @@
             Datep = fp++;
         }
         if (Expp == (ARTOVERFIELD *)NULL) {
-            fp->NeedHeadername = false;
+            fp->NeedHeadername = true;
             fp->Headername = xstrdup(EXPIRES);
             fp->HeadernameLength = strlen(EXPIRES);
             fp->Header = (char *)NULL;
@@ -545,7 +547,7 @@
             Msgidp = fp++;
         }
         if (Overview && Xrefp == (ARTOVERFIELD *)NULL) {
-	    fp->NeedHeadername = false;
+	    fp->NeedHeadername = true;
 	    fp->Headername = xstrdup(XREF);
 	    fp->HeadernameLength = strlen(XREF);
 	    fp->Header = (char *)NULL;




More information about the inn-committers mailing list