INN commit: branches/2.5/scripts (simpleftp.in)

INN Commit rra at isc.org
Sat Apr 16 08:21:50 UTC 2011


    Date: Saturday, April 16, 2011 @ 01:21:50
  Author: iulius
Revision: 9197

The simpleftp script does not switch to binary mode
before transferring files.

If it is used by actsyncd to get active.gz from ftp.isc.org,
the transferred archive is corrupted.

Thanks to Matthias Meyser for the bug report.

Modified:
  branches/2.5/scripts/simpleftp.in

--------------+
 simpleftp.in |    5 +++++
 1 file changed, 5 insertions(+)

Modified: simpleftp.in
===================================================================
--- simpleftp.in	2011-04-16 08:21:13 UTC (rev 9196)
+++ simpleftp.in	2011-04-16 08:21:50 UTC (rev 9197)
@@ -2,6 +2,8 @@
 
 # simpleftp - Rudimentary FTP client.
 #
+# $Id$
+#
 # Author: David Lawrence <tale at isc.org>.
 #         Rewritten by Julien Elie to use Net::FTP.
 #
@@ -75,6 +77,9 @@
   $path =~ s([^/]+$)();
   $localfile =~ s(.*/)();
 
+  $ftp->binary
+    or next;
+
   $ftp->cwd($path)
     or next;
   $ftp->get($localfile)




More information about the inn-committers mailing list