INN commit: trunk/storage/tradindexed (tdx-data.c)

INN Commit rra at isc.org
Mon Jul 11 15:11:01 UTC 2011


    Date: Monday, July 11, 2011 @ 08:11:01
  Author: iulius
Revision: 9239

tradindexed remap of index files when writes out of order

The overview IDX files aren't being re-read after an article is written to
them -- the failing tests (in xref.t, in the test suite) are the places
where a stored overview line is read back to check that it was stored
correctly, except for the first time each group is read (tests 2-5, 11-18)
and when the high water mark is advanced (7-10), which work correctly.

There isn't any mechanism in the source code for the files to be refreshed
except in the case that the high water mark has been advanced.  On systems
which don't have MMAP_MISSES_WRITES, perhaps the underlying write shows
up automatically (?)

Thanks to Wim Lewis for the bug report.

Modified:
  trunk/storage/tradindexed/tdx-data.c

------------+
 tdx-data.c |    2 --
 1 file changed, 2 deletions(-)

Modified: tdx-data.c
===================================================================
--- tdx-data.c	2011-07-11 14:12:18 UTC (rev 9238)
+++ tdx-data.c	2011-07-11 15:11:01 UTC (rev 9239)
@@ -464,8 +464,6 @@
     if ((end > data->high && high > data->high) || data->remapoutoforder) {
         data->remapoutoforder = false;
         unmap_data(data);
-    }
-    if (end > data->high && high > data->high) {
         unmap_index(data);
         map_index(data);
         data->high = high;




More information about the inn-committers mailing list