INN commit: trunk/frontends (pullnews.in)

INN Commit rra at isc.org
Tue Sep 3 18:23:45 UTC 2013


    Date: Tuesday, September 3, 2013 @ 11:23:45
  Author: iulius
Revision: 9535

pullnews:  improve logging when an error occurs during GROUP

Also rewrite a ternary condition to improve readability.

Patch from Geraint A. Edwards.

Modified:
  trunk/frontends/pullnews.in

-------------+
 pullnews.in |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Modified: pullnews.in
===================================================================
--- pullnews.in	2013-08-27 18:41:25 UTC (rev 9534)
+++ pullnews.in	2013-09-03 18:23:45 UTC (rev 9535)
@@ -242,7 +242,7 @@
 my $no_op               = $opt_n || 0;
 my $reader              = $opt_R || 0;
 my $quietness           = $opt_Q || 0;
-my $skip_headers        = defined $opt_H ? lc($opt_H) : '';
+my $skip_headers        = lc($opt_H || '');
 my $logFile             = '>&STDOUT';
 $logFile                = ">>$opt_l" if $opt_l;
 my @hdr_to_match        = split(/\s+/, $opt_m) if defined $opt_m;
@@ -616,7 +616,7 @@
 
     if (!defined($narticles)) { # Group command failed.
         warn sprintf ("Group command failed for $group: %s %s\n",
-                      $fromServer->code(), $fromServer->message());
+                      $fromServer->code() || 'NO_CODE', $fromServer->message());
         return undef;
     }
 



More information about the inn-committers mailing list