INN commit: branches/2.5/frontends (pullnews.in)

INN Commit rra at isc.org
Sat Aug 30 12:09:31 UTC 2014


    Date: Saturday, August 30, 2014 @ 05:09:31
  Author: iulius
Revision: 9667

pullnews: improve logging when an error occurs during GROUP

Also rewrite a ternary condition to improve readability.

Patch from Geraint A. Edwards.

Modified:
  branches/2.5/frontends/pullnews.in

-------------+
 pullnews.in |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Modified: pullnews.in
===================================================================
--- pullnews.in	2014-08-30 12:07:07 UTC (rev 9666)
+++ pullnews.in	2014-08-30 12:09:31 UTC (rev 9667)
@@ -256,7 +256,7 @@
 my $no_op               = $opt_n || 0;
 my $reader              = $opt_R || 0;
 my $quietness           = $opt_Q || 0;
-my $skip_headers        = defined $opt_H ? lc($opt_H) : '';
+my $skip_headers        = lc($opt_H || '');
 my $logFile             = '>&STDOUT';
 $logFile                = ">>$opt_l" if $opt_l;
 my @hdr_to_match        = split(/\s+/, $opt_m) if defined $opt_m;
@@ -655,7 +655,7 @@
 
     if (!defined($narticles)) { # Group command failed.
         warn sprintf ("Group command failed for $group: %s %s\n",
-                      $fromServer->code(), $fromServer->message());
+                      $fromServer->code() || 'NO_CODE', $fromServer->message());
         return undef;
     }
 



More information about the inn-committers mailing list