INN commit: branches/2.5 (2 files)

[INN Commit]

    Date: Monday, February 17, 2014 @ 11:12:15
  Author: iulius
Revision: 9608

improve documentation about using storeonxref with tradspool

Mention in the inn.conf man page that storeonxref needs being set to
true in case the tradspool article storage method is used.

Though a few parts of tradspool handle both values for storeonxref, the
implementation when storeonxref is false is not complete.  For instance,
CrackXref() is still called on the Newsgroups: header once, which
obviously fails.

Modified:
  branches/2.5/doc/pod/inn.conf.pod
  branches/2.5/storage/tradspool/tradspool.c

-------------------------------+
 doc/pod/inn.conf.pod          |    3 +++
 storage/tradspool/tradspool.c |    5 +++++
 2 files changed, 8 insertions(+)

Modified: doc/pod/inn.conf.pod
===================================================================
--- doc/pod/inn.conf.pod	2014-02-17 19:11:30 UTC (rev 9607)
+++ doc/pod/inn.conf.pod	2014-02-17 19:12:15 UTC (rev 9608)
@@ -593,6 +593,9 @@
 rather than according to the newsgroups the control messages are posted
 to.  This is a boolean value and the default is true.
 
+If the tradspool article storage method is used, I<storeonxref> must
+be true.
+
 =item I<useoverchan>
 
 Whether to innd(8) should create overview data internally through

Modified: storage/tradspool/tradspool.c
===================================================================
--- storage/tradspool/tradspool.c	2014-02-17 19:11:30 UTC (rev 9607)
+++ storage/tradspool/tradspool.c	2014-02-17 19:12:15 UTC (rev 9608)
@@ -454,6 +454,11 @@
 	SMseterror(SMERR_INTERNAL, "attr is NULL");
 	return false;
     }
+    /* Though a few parts of tradspool handle both values for storeonxref,
+     * the implementation when storeonxref is false is not complete.
+     * For instance, CrackXref() is still called on the Newsgroups: header
+     * once, which obviously fails.
+     */ 
     if (!innconf->storeonxref) {
         warn("tradspool: storeonxref needs to be true");
 	SMseterror(SMERR_INTERNAL, "storeonxref needs to be true");