INN commit: trunk (innd/rc.c innfeed/host.c innfeed/main.c)

INN Commit rra at isc.org
Sun Jun 14 10:10:37 UTC 2015


    Date: Sunday, June 14, 2015 @ 03:10:37
  Author: iulius
Revision: 9897

innfeed, innd: fix boring uninteresting memory leaks

These aren't serious leaks, but do cause noise in analysis
tools.

Thanks to Richard Kettlewell for the patch.

Modified:
  trunk/innd/rc.c
  trunk/innfeed/host.c
  trunk/innfeed/main.c

----------------+
 innd/rc.c      |    2 ++
 innfeed/host.c |    4 ++++
 innfeed/main.c |    1 +
 3 files changed, 7 insertions(+)

Modified: innd/rc.c
===================================================================
--- innd/rc.c	2015-06-14 10:09:47 UTC (rev 9896)
+++ innd/rc.c	2015-06-14 10:10:37 UTC (rev 9897)
@@ -1799,6 +1799,8 @@
 
     /* Get the list of hosts we handle. */
     RCreadlist();
+
+    free(fds);
 }
 
 

Modified: innfeed/host.c
===================================================================
--- innfeed/host.c	2015-06-14 10:09:47 UTC (rev 9896)
+++ innfeed/host.c	2015-06-14 10:10:37 UTC (rev 9897)
@@ -2582,6 +2582,10 @@
   else if (*filename == '\0')
     die ("Can't set status file name with an empty string\n") ;
 
+  /* statusFile may already be initialized (several status-file: lines,
+   * reload of the config file, shutdown process). */
+  free(statusFile);
+
   if (*filename == '/')
     statusFile = xstrdup (filename) ;
   else {

Modified: innfeed/main.c
===================================================================
--- innfeed/main.c	2015-06-14 10:09:47 UTC (rev 9896)
+++ innfeed/main.c	2015-06-14 10:10:37 UTC (rev 9897)
@@ -366,6 +366,7 @@
   debugFile = concatpath(innconf->pathlog, DEBUG_FILE);
   if (loggingLevel == 0 && fileExistsP (debugFile))
     loggingLevel = 1 ;
+  free(debugFile);
 
   if (logFile == NULL && ! isatty (fileno (stderr)))
     logFile = concatpath(innconf->pathlog, LOG_FILE);



More information about the inn-committers mailing list