INN commit: trunk/nnrpd (commands.c)

INN Commit rra at isc.org
Sun May 3 15:05:46 UTC 2015


    Date: Sunday, May 3, 2015 @ 08:05:45
  Author: iulius
Revision: 9848

nnrpd/commands.c:  correct sense of PERMgeneric reply

The comment has always been wrong, as well as the return value for
~15 years...

Thanks to Richard Kettlewell for the patch.

Modified:
  trunk/nnrpd/commands.c

------------+
 commands.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Modified: commands.c
===================================================================
--- commands.c	2015-05-03 15:01:03 UTC (rev 9847)
+++ commands.c	2015-05-03 15:05:45 UTC (rev 9848)
@@ -88,8 +88,8 @@
 
 /*  Returns:
 **    -1 for problem (such as no such authenticator, etc.).
-**     0 for authentication succeeded.
-**     1 for authentication failed.
+**     1 for authentication succeeded.
+**     0 for authentication failed.
 */
 static char *PERMauthstring;
 
@@ -202,7 +202,7 @@
 
     waitpid(pid, &status, 0);
     if (!WIFEXITED(status) || WEXITSTATUS(status) != 0)
-        return 1;
+        return 0;
 
     if ((p = strchr(path, '\n')) != NULL)
 	*p = '\0';
@@ -233,7 +233,7 @@
     //for (i = 0; fields[i] && i < 5; i++)
     //    syslog(L_NOTICE, "fields[%d] = %s\n", i, fields[i]);
 
-    return 0;
+    return 1;
 }
 
 



More information about the inn-committers mailing list