INN commit: trunk/history/hisv6 (hisv6.c)

INN Commit rra at isc.org
Thu May 5 13:21:30 UTC 2016


    Date: Thursday, May 5, 2016 @ 06:21:29
  Author: iulius
Revision: 10030

Mention that mips define dev_t to be 64-bits whereas st_dev is 32-bits

It does not matter, though, in our use cases.

Modified:
  trunk/history/hisv6/hisv6.c

---------+
 hisv6.c |    8 ++++++++
 1 file changed, 8 insertions(+)

Modified: hisv6.c
===================================================================
--- hisv6.c	2016-05-05 13:18:31 UTC (rev 10029)
+++ hisv6.c	2016-05-05 13:21:29 UTC (rev 10030)
@@ -270,6 +270,10 @@
 
     h->nextcheck = 0;
     h->st.st_ino = (ino_t)-1;
+    /* FIXME - mips defines dev_t to be 64-bits whereas st_dev is 32-bits,
+     * so we have an overflow when casting to dev_t.
+     * As we always compare against st_ino as well, it shouldn't
+     * matter though. */
     h->st.st_dev = (dev_t)-1;
     return r;
 }
@@ -478,6 +482,10 @@
     h->dirty = 0;
     h->synccount = 0;
     h->st.st_ino = (ino_t)-1;
+    /* FIXME - mips defines dev_t to be 64-bits whereas st_dev is 32-bits,
+     * so we have an overflow when casting to dev_t.
+     * As we always compare against st_ino as well, it shouldn't
+     * matter though. */
     h->st.st_dev = (dev_t)-1;
     return h;
 }



More information about the inn-committers mailing list