[InterNetNews/inn] 4754f9: Stricter validation of article numbers

Julien ÉLIE noreply at github.com
Sun Oct 17 08:37:49 UTC 2021


  Branch: refs/heads/2.6
  Home:   https://github.com/InterNetNews/inn
  Commit: 4754f9c0c39b1a007ac43875562e07e65b6ca57b
      https://github.com/InterNetNews/inn/commit/4754f9c0c39b1a007ac43875562e07e65b6ca57b
  Author: Richard Kettlewell <rjk at greenend.org.uk>
  Date:   2021-10-17 (Sun, 17 Oct 2021)

  Changed paths:
    M .gitignore
    M MANIFEST
    M lib/numbers.c
    M support/mkmanifest
    M tests/Makefile
    M tests/TESTS
    A tests/lib/artnumber-t.c

  Log Message:
  -----------
  Stricter validation of article numbers

This brings the implementation largely in line with RFC3977, and fixes
anomalous behavior when very large article numbers are passed in NNTP
commands, e.g. OVER reduces the article number mod 2^32 and then
returns an unexpected range of articles.

Adds tests for IsValidArticleNumber and IsValidRange.


  Commit: d165b11fec6bb314a7df83db67075ab8d8d414c7
      https://github.com/InterNetNews/inn/commit/d165b11fec6bb314a7df83db67075ab8d8d414c7
  Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
  Date:   2021-10-17 (Sun, 17 Oct 2021)

  Changed paths:
    M MANIFEST
    M doc/pod/news.pod
    M lib/Makefile
    A lib/artnumber.c
    R lib/numbers.c

  Log Message:
  -----------
  Rename lib/numbers.c to lib/artnumber.c

It is a better name for this file, now we also have a test suite for
article numbers.
Also, add credits to Richard Kettlewell for his improvement in article
validation.


Compare: https://github.com/InterNetNews/inn/compare/11932f1e2b42...d165b11fec6b


More information about the inn-committers mailing list