[InterNetNews/inn] c55cb3: Fix double free in tdx-util

[Russ Allbery]

  Branch: refs/heads/main
  Home:   https://github.com/InterNetNews/inn
  Commit: c55cb30c4ce4d405bef15c3467e84781512b7580
      https://github.com/InterNetNews/inn/commit/c55cb30c4ce4d405bef15c3467e84781512b7580
  Author: Russ Allbery <eagle at eyrie.org>
  Date:   2021-09-13 (Mon, 13 Sep 2021)

  Changed paths:
    M storage/tradindexed/tdx-util.c

  Log Message:
  -----------
  Fix double free in tdx-util

The data structure is designed to be cached with a reference count,
and therefore is freed when a search is closed if it hasn't been
added to a cache.  tdx-util was unaware of that and was freeing it
again explicitly, causing a double free and a test failure (but no
security implications, since it happened immediately before process
exit).  Remove the duplicate free.

Add some cleanup to an early return path in the same function.