[InterNetNews/inn] f2adeb: Stricter validation of article numbers

Julien ÉLIE noreply at github.com
Sat Sep 18 12:37:14 UTC 2021


  Branch: refs/heads/main
  Home:   https://github.com/InterNetNews/inn
  Commit: f2adebc9392b9266fedefd19f819e5d620dfa8df
      https://github.com/InterNetNews/inn/commit/f2adebc9392b9266fedefd19f819e5d620dfa8df
  Author: Richard Kettlewell <rjk at greenend.org.uk>
  Date:   2021-09-18 (Sat, 18 Sep 2021)

  Changed paths:
    M .gitignore
    M MANIFEST
    M lib/numbers.c
    M support/mkmanifest
    M tests/Makefile
    M tests/TESTS
    A tests/lib/artnumber-t.c

  Log Message:
  -----------
  Stricter validation of article numbers

This brings the implementation largely in line with RFC3977, and fixes
anomalous behavior when very large article numbers are passed in NNTP
commands, e.g. OVER reduces the article number mod 2^32 and then
returns an unexpected range of articles.

Adds tests for IsValidArticleNumber and IsValidRange.


  Commit: 3df736e34a99518a2b23a85fa9c9793ab263dd48
      https://github.com/InterNetNews/inn/commit/3df736e34a99518a2b23a85fa9c9793ab263dd48
  Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
  Date:   2021-09-18 (Sat, 18 Sep 2021)

  Changed paths:
    M MANIFEST
    M doc/pod/news.pod
    M lib/Makefile
    A lib/artnumber.c
    R lib/numbers.c

  Log Message:
  -----------
  Rename lib/numbers.c to lib/artnumber.c

It is a better name for this file, now we also have a test suite for
article numbers.
Also, add credits to Richard Kettlewell for his improvement in article
validation.


Compare: https://github.com/InterNetNews/inn/compare/024dbc49e21c...3df736e34a99


More information about the inn-committers mailing list