[InterNetNews/inn] 8e9611: IsValidMessageID() self-initializes what it needs

[Julien ÉLIE]

  Branch: refs/heads/2.7
  Home:   https://github.com/InterNetNews/inn
  Commit: 8e96110c661494bce79ce19ed38b1c8176334038
      https://github.com/InterNetNews/inn/commit/8e96110c661494bce79ce19ed38b1c8176334038
  Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
  Date:   2023-02-20 (Mon, 20 Feb 2023)

  Changed paths:
    M control/gencancel.c
    M include/inn/libinn.h
    M innd/art.c
    M lib/messageid.c
    M nnrpd/nnrpd.c
    M tests/lib/messageid-t.c

  Log Message:
  -----------
  IsValidMessageID() self-initializes what it needs

No longer call InitializeMessageIDcclass() before any use of
IsValidMessageID().  Let the function handle it itself.


  Commit: 62eb74279b52af4077bc1a239bb17182ea4f54f5
      https://github.com/InterNetNews/inn/commit/62eb74279b52af4077bc1a239bb17182ea4f54f5
  Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
  Date:   2023-02-20 (Mon, 20 Feb 2023)

  Changed paths:
    M doc/pod/news.pod
    M include/inn/libinn.h
    M lib/innconf.c
    M lib/messageid.c
    M nnrpd/perm.c
    M tests/lib/messageid-t.c

  Log Message:
  -----------
  Check the syntax of the domain parameter

If domain (manually set, or the FQDN) has invalid characters in
inn.conf or readers.conf, just abort with a fatal error.  It is a basic
configuration error and we do not want to generate invalid Message-IDs.

Add a new IsValidDomain() function to validate the right-hand part of
a Message-ID.  Call it to validate the FQDN when domain is unset, and
the domain when set.

close #242


  Commit: 3a3734fcbf113dee8f3397afc941fa15203ed7de
      https://github.com/InterNetNews/inn/commit/3a3734fcbf113dee8f3397afc941fa15203ed7de
  Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
  Date:   2023-02-20 (Mon, 20 Feb 2023)

  Changed paths:
    M control/gencancel.c
    M doc/FAQ
    M doc/pod/inn.conf.pod
    M doc/pod/libinn.pod
    M doc/pod/news.pod
    M doc/pod/readers.conf.pod
    M frontends/inews.c
    M lib/innconf.c
    M lib/messageid.c
    M nnrpd/commands.c
    M nnrpd/nnrpd.h
    M nnrpd/perm.c
    M nnrpd/post.c

  Log Message:
  -----------
  Keep user-supplied domain in readers.conf

Customizing the domain part of Message-IDs generated by nnrpd and the
server name indicated in Injection-Info header fields is now easier:
the domain parameter in the access blocks of readers.conf can be
directly used (without setting virtualhost as it was previously the
case).

An expicitly-set configuration option should override whatever is
discovered while probing around on the system.  So we now use domain
unconditionally if it is set in readers.conf for forming message
identifiers and Injection-Info.  But keep backwards-compatibility by
not using domain if only set in inn.conf (previous versions of INN only
use it if virtualhost is also set to true).

Document domain as a first-class configuration parameter for access
groups in readers.conf, saying that it changes the way Message-IDs and
Injection-Info are constructed.

Update wording in the FAQ and various documentation (inn.conf, libinn,
readers.conf, comments in C code).

close #243


Compare: https://github.com/InterNetNews/inn/compare/7f7347afd4ea...3a3734fcbf11