[InterNetNews/inn] c69493: ovsqlite: Fix latent bug in write_request()

Julien ÉLIE noreply at github.com
Mon Jan 9 20:59:26 UTC 2023


  Branch: refs/heads/2.7
  Home:   https://github.com/InterNetNews/inn
  Commit: c6949343e4c3b9566a1d3e2f82fe3e486f16f324
      https://github.com/InterNetNews/inn/commit/c6949343e4c3b9566a1d3e2f82fe3e486f16f324
  Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
  Date:   2023-01-09 (Mon, 09 Jan 2023)

  Changed paths:
    M storage/ovsqlite/ovsqlite.c

  Log Message:
  -----------
  ovsqlite: Fix latent bug in write_request()

data, and not request->data, is expected to be written.
They are the same except in a rare event: when the request is larger than
the socket's output buffer AND a signal arrives while the write call blocks.

Bug found with a "variable set but not used" gcc warning.

Fix confirmed by Bo Lindbergh, author of ovsqlite.




More information about the inn-committers mailing list