[InterNetNews/inn] 821b27: nnrpd: avoid hang due to misplaced select()

Julien ÉLIE noreply at github.com
Mon Jun 26 17:09:08 UTC 2023


  Branch: refs/heads/main
  Home:   https://github.com/InterNetNews/inn
  Commit: 821b271b58be720e4e3d53d967e91e203d7aa370
      https://github.com/InterNetNews/inn/commit/821b271b58be720e4e3d53d967e91e203d7aa370
  Author: Enrik Berkhan <Enrik.Berkhan at inka.de>
  Date:   2023-06-26 (Mon, 26 Jun 2023)

  Changed paths:
    M nnrpd/line.c

  Log Message:
  -----------
  nnrpd: avoid hang due to misplaced select()

The select() call in nnrpd's input data processing is moved right
before the related read() call to avoid blocking when it shouldn't.

Without this change, there could still remain data to be inflated, that
has already been read, if compression had been activated.  The select()
can then time out because the client might already have sent all data
before, and the yet to be inflated data will not be used until after
the timeout.

Resolves: #269


  Commit: 3feead0c09ebc50890fc70561074ca074bd93981
      https://github.com/InterNetNews/inn/commit/3feead0c09ebc50890fc70561074ca074bd93981
  Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
  Date:   2023-06-26 (Mon, 26 Jun 2023)

  Changed paths:
    M CONTRIBUTORS
    M doc/pod/news.pod

  Log Message:
  -----------
  Update NEWS and CONTRIBUTORS for the last commit

Thanks again Enrik!

see #269 #270


Compare: https://github.com/InterNetNews/inn/compare/ca31123c455f...3feead0c09eb


More information about the inn-committers mailing list