[InterNetNews/inn] 59126b: Comment fixes (no longer necessary)

Sun Feb 11 09:15:43 UTC 2024

  Branch: refs/heads/2.7
  Home:   https://github.com/InterNetNews/inn
  Commit: 59126b43f8f155cca8fcee688adf8cc3a7f84c28
      https://github.com/InterNetNews/inn/commit/59126b43f8f155cca8fcee688adf8cc3a7f84c28
  Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
  Date:   2024-02-11 (Sun, 11 Feb 2024)

  Changed paths:
    M Makefile.global.in
    M storage/timecaf/caf.c

  Log Message:
  -----------
  Comment fixes (no longer necessary)

  Commit: 4fbf4b764bf928d9dfae7b991188d5a6e45a9581
      https://github.com/InterNetNews/inn/commit/4fbf4b764bf928d9dfae7b991188d5a6e45a9581
  Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
  Date:   2024-02-11 (Sun, 11 Feb 2024)

  Changed paths:
    M doc/pod/innfeed.conf.pod

  Log Message:
  -----------
  Typo in debug-level in innfeed.conf manual page

  Commit: 1455a497940cc9a0aae099f96ec3a8938fedc5c4
      https://github.com/InterNetNews/inn/commit/1455a497940cc9a0aae099f96ec3a8938fedc5c4
  Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
  Date:   2024-02-11 (Sun, 11 Feb 2024)

  Changed paths:
    M backends/delayer.in
    M doc/pod/pullnews.pod

  Log Message:
  -----------
  Improve doc, better explain parameters to change

  Commit: 1a16a39fa7f54c55ff54ae0df35eba7fb59ac8ac
      https://github.com/InterNetNews/inn/commit/1a16a39fa7f54c55ff54ae0df35eba7fb59ac8ac
  Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
  Date:   2024-02-11 (Sun, 11 Feb 2024)

  Changed paths:
    M backends/inndf.c
    M doc/pod/news.pod

  Log Message:
  -----------
  inndf: Use long long for 64-bit numbers (on i686)

The number was stored in a long int, which is not enough to store
64-bit numbers on 32-bit platforms.  We now store it in a long long
int.

inndf was otherwise returning 0 because of an overflow, even when
compiled with large file support.

close #296

  Commit: 22a7ca918d60a21dcda483a59cf89a72639158b0
      https://github.com/InterNetNews/inn/commit/22a7ca918d60a21dcda483a59cf89a72639158b0
  Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
  Date:   2024-02-11 (Sun, 11 Feb 2024)

  Changed paths:
    M frontends/inews.c
    M innfeed/article.c
    M innfeed/imap_connection.c
    M lib/confparse.c
    M lib/dbz.c
    M lib/uwildmat.c
    M tests/runtests.c

  Log Message:
  -----------
  Reformat C code with clang-format 17.0.6

  Commit: 2ff1cca08f6e3cf942f4a203bb162efe1dece04e
      https://github.com/InterNetNews/inn/commit/2ff1cca08f6e3cf942f4a203bb162efe1dece04e
  Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
  Date:   2024-02-11 (Sun, 11 Feb 2024)

  Changed paths:
    M .git-blame-ignore-revs

  Log Message:
  -----------
  Add previous commit to git blame ignore

  Commit: a5692de0e0b87c344d7425d455dec49078e082e2
      https://github.com/InterNetNews/inn/commit/a5692de0e0b87c344d7425d455dec49078e082e2
  Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
  Date:   2024-02-11 (Sun, 11 Feb 2024)

  Changed paths:
    M lib/xmalloc.c

  Log Message:
  -----------
  xmalloc: Suppress GCC warnings

The latest GCC produces incorrect warnings about using the pointer
passed to realloc and reallocarray when the functions return NULL.
Suppress that warning, and change the call syntax for the error
handler to avoid tickling a bug in clang-format.

Patch from upstream (rra-c-util).

  Commit: 2a80bc8e66cc6de3933cd0d0f4ea647fdb075d4a
      https://github.com/InterNetNews/inn/commit/2a80bc8e66cc6de3933cd0d0f4ea647fdb075d4a
  Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
  Date:   2024-02-11 (Sun, 11 Feb 2024)

  Changed paths:
    M scripts/inncheck.in

  Log Message:
  -----------
  inncheck: Update the list of programs in pathbin

  Commit: 566967af039eb00bcef92373bc474c330b9e4011
      https://github.com/InterNetNews/inn/commit/566967af039eb00bcef92373bc474c330b9e4011
  Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
  Date:   2024-02-11 (Sun, 11 Feb 2024)

  Changed paths:
    M doc/pod/inn.conf.pod
    M doc/pod/install.pod
    M doc/pod/news.pod
    M doc/pod/storage.conf.pod
    M frontends/cnfsstat.in
    M include/inn/storage.h
    M innd/art.c
    M samples/storage.conf
    M scripts/inncheck.in
    M storage/interface.c
    M storage/interface.h

  Log Message:
  -----------
  storage.conf: Add filtered option

New filtered option in storage.conf to store articles which have been
rejected by a Perl or Python filter for innd in a separate storage
class.

Thanks to Christoph Biedl for the patch.

close #38

  Commit: f22319d8994db543fe16ccb4a76dd17dd652e27a
      https://github.com/InterNetNews/inn/commit/f22319d8994db543fe16ccb4a76dd17dd652e27a
  Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
  Date:   2024-02-11 (Sun, 11 Feb 2024)

  Changed paths:
    M storage/timecaf/timecaf.c

  Log Message:
  -----------
  Reformat C code with clang-format 17.0.6

  Commit: c317fbb0f81f0d31f6b762cbd9c478138877d566
      https://github.com/InterNetNews/inn/commit/c317fbb0f81f0d31f6b762cbd9c478138877d566
  Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
  Date:   2024-02-11 (Sun, 11 Feb 2024)

  Changed paths:
    M .git-blame-ignore-revs

  Log Message:
  -----------
  Add previous commit to git blame ignore

  Commit: a9d5bcfe0c0618911c5feef72a1cb19a98d91d78
      https://github.com/InterNetNews/inn/commit/a9d5bcfe0c0618911c5feef72a1cb19a98d91d78
  Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
  Date:   2024-02-11 (Sun, 11 Feb 2024)

  Changed paths:
    M backends/innxmit.c

  Log Message:
  -----------
  innxmit: Fix the count of retries

Reintroduce the incrementation of the retries variable, which was
inadvertently removed in a previous commit.

see #175

  Commit: a44bd8f45d323cdd4f7ac4c2f629191f1536d10b
      https://github.com/InterNetNews/inn/commit/a44bd8f45d323cdd4f7ac4c2f629191f1536d10b
  Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
  Date:   2024-02-11 (Sun, 11 Feb 2024)

  Changed paths:
    M frontends/cnfsstat.in
    M scripts/innreport_inn.pm

  Log Message:
  -----------
  innreport: Recognize the filtered log in cnfsstat

Also, the filtered parameter in storage.conf is case-insensitive.

see #38

  Commit: 0910aaa87b7f03268f9390aaba57dfd1ed5ffdee
      https://github.com/InterNetNews/inn/commit/0910aaa87b7f03268f9390aaba57dfd1ed5ffdee
  Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
  Date:   2024-02-11 (Sun, 11 Feb 2024)

  Changed paths:
    M m4/python.m4

  Log Message:
  -----------
  Use python-config to find Python link flags

Thanks to Matthias Klose for the bug report, and proposal of patch
using python-config.  Fall back on the previous behaviour when
python-config is not installed.

Also, remove LOCALMODLIBS as it should not actually be used and breaks
the build with recent Python versions.  Only keep BASEMODLIBS.

close #295

  Commit: 2567813124e17f1328df4258a9693ebf95e0c26e
      https://github.com/InterNetNews/inn/commit/2567813124e17f1328df4258a9693ebf95e0c26e
  Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
  Date:   2024-02-11 (Sun, 11 Feb 2024)

  Changed paths:
    M contrib/expirectl.c
    M storage/timecaf/caf.c
    M storage/timecaf/caf.h

  Log Message:
  -----------
  Fix use of statvfs on 32-bit platforms

A long type (4 bytes) cannot contain the available number of inodes and
like on 32-bit architectures with large file support enabled.  A long
long type is needed (8 bytes).

see #296

  Commit: 57221c4d7b7cf134692f5b78d003eada77b1273e
      https://github.com/InterNetNews/inn/commit/57221c4d7b7cf134692f5b78d003eada77b1273e
  Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
  Date:   2024-02-11 (Sun, 11 Feb 2024)

  Changed paths:
    M doc/pod/inn.conf.pod

  Log Message:
  -----------
  Better document overcachesize and rlimitnofile

  Commit: d3637fa86b8a0f999091435dc27a79001baef600
      https://github.com/InterNetNews/inn/commit/d3637fa86b8a0f999091435dc27a79001baef600
  Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
  Date:   2024-02-11 (Sun, 11 Feb 2024)

  Changed paths:
    M doc/pod/incoming.conf.pod

  Log Message:
  -----------
  Document the order lines in incoming.conf are read

  Commit: b31f35f9f28a459c77d7fb8dabf0a6f5478fdd8c
      https://github.com/InterNetNews/inn/commit/b31f35f9f28a459c77d7fb8dabf0a6f5478fdd8c
  Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
  Date:   2024-02-11 (Sun, 11 Feb 2024)

  Changed paths:
    M doc/pod/inn.conf.pod
    M doc/pod/nnrpd.pod

  Log Message:
  -----------
  Document certificates outside Let's Encrypt

  Commit: 68d6315184d0cf634707cd8dc6a09067cc67770d
      https://github.com/InterNetNews/inn/commit/68d6315184d0cf634707cd8dc6a09067cc67770d
  Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
  Date:   2024-02-11 (Sun, 11 Feb 2024)

  Changed paths:
    M doc/pod/inews.pod
    M doc/pod/rnews.pod

  Log Message:
  -----------
  Improve documentation of inews and rnews

Add examples, explain the use case of POST vs IHAVE, and no longer say
inews only posts to the local news server.

  Commit: e4783cbd89a6a3a74f1584c1850febbad83d36f2
      https://github.com/InterNetNews/inn/commit/e4783cbd89a6a3a74f1584c1850febbad83d36f2
  Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
  Date:   2024-02-11 (Sun, 11 Feb 2024)

  Changed paths:
    M doc/pod/inews.pod
    M doc/pod/inn.conf.pod
    M frontends/inews.c

  Log Message:
  -----------
  Better document NNTPSERVER

Also fix the name of tinews.pl.

  Commit: f837e27ce6ee9cf51ec273a35c355d3968938386
      https://github.com/InterNetNews/inn/commit/f837e27ce6ee9cf51ec273a35c355d3968938386
  Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
  Date:   2024-02-11 (Sun, 11 Feb 2024)

  Changed paths:
    M doc/pod/storage.conf.pod

  Log Message:
  -----------
  Better explain the role of storage classes

  Commit: 841f0fd7927d90200ac5b19b9d7355ae44127bbd
      https://github.com/InterNetNews/inn/commit/841f0fd7927d90200ac5b19b9d7355ae44127bbd
  Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
  Date:   2024-02-11 (Sun, 11 Feb 2024)

  Changed paths:
    M innfeed/imap_connection.c

  Log Message:
  -----------
  imap_connection: Silent warning on Clang version

-Wcast-function-type has been introduced in Clang 13.

  Commit: 0e4e261ac11b158a3175702f690999f0a0fec5df
      https://github.com/InterNetNews/inn/commit/0e4e261ac11b158a3175702f690999f0a0fec5df
  Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
  Date:   2024-02-11 (Sun, 11 Feb 2024)

  Changed paths:
    M frontends/feedone.c

  Log Message:
  -----------
  feedone: Add noreturn attribute to a function

  Commit: 8ebc9560ffc95d3fb44c9c284aacb2ca753139f3
      https://github.com/InterNetNews/inn/commit/8ebc9560ffc95d3fb44c9c284aacb2ca753139f3
  Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
  Date:   2024-02-11 (Sun, 11 Feb 2024)

  Changed paths:
    M frontends/sys2nf.c

  Log Message:
  -----------
  sys2nf: Fix the -Wcomma warning from Clang

  Commit: 3499717987d28ab384d37a374b90eb608cc3d4c1
      https://github.com/InterNetNews/inn/commit/3499717987d28ab384d37a374b90eb608cc3d4c1
  Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
  Date:   2024-02-11 (Sun, 11 Feb 2024)

  Changed paths:
    M lib/hex.c

  Log Message:
  -----------
  lib/hex: Remove unused variable

Warning from Clang 17.

  Commit: 6ef5ad0a10f3d9a080d2356ff550565abbb89c31
      https://github.com/InterNetNews/inn/commit/6ef5ad0a10f3d9a080d2356ff550565abbb89c31
  Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
  Date:   2024-02-11 (Sun, 11 Feb 2024)

  Changed paths:
    M frontends/ovdb_stat.c

  Log Message:
  -----------
  ovdb_stat: Silent -Wnull-pointer-subtraction

Substracting (char *) 0 for alignment purpose is supported by compilers
like GCC or Clang, but is undefined behaviour by the C Standard as it is
unknown whether all hardware platforms can actually process such pointer
arithmetic (many, if not all, can anyway).

  Commit: d96c93b778935536521e3681b6d71d91de5ebfb8
      https://github.com/InterNetNews/inn/commit/d96c93b778935536521e3681b6d71d91de5ebfb8
  Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
  Date:   2024-02-11 (Sun, 11 Feb 2024)

  Changed paths:
    M authprogs/radius.c
    M doc/pod/incoming.conf.pod
    M doc/pod/inn-radius.conf.pod
    M doc/pod/innfeed.conf.pod
    M innd/rc.c
    M innfeed/configfile.l
    M samples/incoming.conf
    M scripts/inncheck.in

  Log Message:
  -----------
  Allow on, off, yes and no values for booleans

incoming.conf, innfeed.conf and inn-radius.conf were not allowing
these values.  Now homogenize it, and instruct inncheck to globally
allow these values (it previously wrongly reported as an error the
use of these values in other configuration files like storage.conf or
readers.conf).

  Commit: 5cd5112811dd24a2c5a4a748ae5b36320d4bfe1a
      https://github.com/InterNetNews/inn/commit/5cd5112811dd24a2c5a4a748ae5b36320d4bfe1a
  Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
  Date:   2024-02-11 (Sun, 11 Feb 2024)

  Changed paths:
    M backends/actsync.c
    M backends/innxmit.c
    M backends/ninpaths.c
    M expire/makedbz.c
    M frontends/ctlinnd.c
    M frontends/getlist.c
    M frontends/ovdb_init.c
    M frontends/ovdb_server.c
    M frontends/ovdb_stat.c
    M include/inn/nntp.h
    M innd/cc.c
    M innd/chan.c
    M innd/nc.c
    M innd/rc.c
    M innd/site.c
    M innfeed/article.c
    M innfeed/configfile.y
    M innfeed/connection.c
    M innfeed/endpoint.c
    M innfeed/host.c
    M innfeed/imap_connection.c
    M innfeed/main.c
    M innfeed/misc.c
    M lib/innconf.c
    M lib/nntp.c
    M nnrpd/commands.c
    M nnrpd/list.c
    M nnrpd/misc.c
    M nnrpd/newnews.c
    M nnrpd/nnrpd.c
    M nnrpd/perl.c
    M nnrpd/sasl.c
    M nnrpd/tls.c
    M storage/buffindexed/buffindexed.c
    M storage/cnfs/cnfs.c
    M storage/ov.c
    M storage/ovdb/ovdb.c
    M storage/overdata.c
    M storage/overview.c
    M storage/ovsqlite/ovsqlite.c
    M storage/timecaf/timecaf.c
    M storage/timehash/timehash.c
    M storage/tradindexed/tdx-group.c
    M storage/tradspool/tradspool.c
    M tests/innd/artparse-t.c

  Log Message:
  -----------
  Fix use of signed / unsigned variables

With new -Wformat-signedness GCC warning.

  Commit: 8f8d5d24fc0331fe5ef811911f641887214ff65e
      https://github.com/InterNetNews/inn/commit/8f8d5d24fc0331fe5ef811911f641887214ff65e
  Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
  Date:   2024-02-11 (Sun, 11 Feb 2024)

  Changed paths:
    M configure.ac

  Log Message:
  -----------
  Add new warnings from GCC 13

Enable -fstrict-aliasing -fstrict-flex-arrays=3 -Wformat-signedness
-Warray-bounds=3 -Wuse-after-free=3

Also silent two warnings from Clang: -Wno-unsafe-buffer-usage
-Wno-reserved-identifier

Compare: https://github.com/InterNetNews/inn/compare/955199babd18...8f8d5d24fc03