[InterNetNews/inn] 444e0a: No need running perltidy on the site directory
Julien ÉLIE
noreply at github.com
Sun Oct 6 20:10:19 UTC 2024
Branch: refs/heads/2.7
Home: https://github.com/InterNetNews/inn
Commit: 444e0aef68d9ad7651e11818ee0825ebf7949772
https://github.com/InterNetNews/inn/commit/444e0aef68d9ad7651e11818ee0825ebf7949772
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M Makefile
Log Message:
-----------
No need running perltidy on the site directory
Commit: 74a7342c49906849ab92c0ba94f8be1a9df0ad20
https://github.com/InterNetNews/inn/commit/74a7342c49906849ab92c0ba94f8be1a9df0ad20
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M Makefile
M backends/send-uucp.in
M contrib/stathist.in
M contrib/tunefeed.in
M control/controlchan.in
M control/perl-nocem.in
M perl/INN/ovsqlite_client.pm
Log Message:
-----------
Add new "make code-check" command
Only perltidy warnings are currently run. Other static code analyzers
will be added in the future.
Add prototypes to Perl functions with optional parameters.
Found by "perltidy --warn-mismatched-args".
Commit: da4b9ff34aabebd340bcf264aa7f1ad6cb735d89
https://github.com/InterNetNews/inn/commit/da4b9ff34aabebd340bcf264aa7f1ad6cb735d89
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M Makefile
M backends/send-uucp.in
M contrib/authmysql.in
M contrib/nnrp.access2readers.conf.in
M contrib/stathist.in
M control/controlchan.in
M control/modules/checkgroups.pl
M control/modules/newgroup.pl
M frontends/cnfsstat.in
M frontends/mailpost.in
M frontends/pullnews.in
M frontends/scanspool.in
M history/buildconfig.in
M perl/INN/Utils/Shlock.pm.in
M perl/INN/ovsqlite_client.pm
M samples/nnrpd_access.pl.in
M scripts/inncheck.in
M scripts/innreport.in
M scripts/innreport_inn.pm
M scripts/innupgrade.in
M storage/buildconfig.in
M storage/ovsqlite/sqlite-helper-gen.in
Log Message:
-----------
Fix reused Perl variable names at different scopes
No bug detected because of reused variable names, but better
disambiguate their names.
Found by "perltidy --warn-variable-types".
Commit: 9d90acc26ad5bc0b73b29e63bc3253446fa18299
https://github.com/InterNetNews/inn/commit/9d90acc26ad5bc0b73b29e63bc3253446fa18299
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M Makefile
M backends/delayer.in
M backends/send-uucp.in
M contrib/analyze-traffic.in
M contrib/archivegz.in
M contrib/authmysql.in
M control/modules/checkgroups.pl
M control/modules/ihave.pl
M control/modules/newgroup.pl
M control/modules/rmgroup.pl
M control/modules/sendme.pl
M control/perl-nocem.in
M frontends/cnfsstat.in
M frontends/mailpost.in
M frontends/pullnews.in
M history/buildconfig.in
M samples/filter_innd.pl
M samples/nnrpd_auth.pl.in
M scripts/inncheck.in
M scripts/innreport.in
M scripts/innreport_inn.pm
M scripts/innupgrade.in
M storage/buildconfig.in
Log Message:
-----------
Clean or rename unused variables in Perl code
No bug detected because of unused variables, but better audit their
uses.
Found by "perltidy --warn-variable-types".
Commit: 408702015603c94a8491b00f036c35c3627d6809
https://github.com/InterNetNews/inn/commit/408702015603c94a8491b00f036c35c3627d6809
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M lib/buffer.c
M lib/getnameinfo.c
M lib/network.c
M support/getrra-c-util
M tests/lib/getaddrinfo-t.c
M tests/lib/getnameinfo-t.c
Log Message:
-----------
Update rra-c-util with upstream version
Declare a bunch of pointers const that cppcheck figured out were never
written to, and move a variable initialization to make cppcheck happy.
Commit: 7bc2fb14269af69bd95798cf7e12497bbe0a44e0
https://github.com/InterNetNews/inn/commit/7bc2fb14269af69bd95798cf7e12497bbe0a44e0
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M samples/filter_nnrpd.pl
Log Message:
-----------
Typo in variable name in filter_nnrpd.pl sample
Use $hdr{'__BODY__'} in filter_nnrpd.pl sample instead of $body, as
this is the actual name of the variable containing the article body.
Commit: 598c088abcea229262f74dce948ace4998290c8b
https://github.com/InterNetNews/inn/commit/598c088abcea229262f74dce948ace4998290c8b
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M scripts/innreport.in
Log Message:
-----------
innreport: Improve line breaks in formatting
Add parentheses around some arithmetic operations in order to have a
better visual rendering.
Commit: 46d938af04b819b5de537a9b6ed0e6738c76372c
https://github.com/InterNetNews/inn/commit/46d938af04b819b5de537a9b6ed0e6738c76372c
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M scripts/innreport_inn.pm
Log Message:
-----------
innreport_inn.pm: Hide non-printable chars
Convert non-printable chars to "?" in the "NNRP unrecognized commands"
section of reports, so as not to break the alignments of columns nor
output invalid HTML.
Commit: 32f5e6024ae80957a42f6cfd99eb7615764d2e24
https://github.com/InterNetNews/inn/commit/32f5e6024ae80957a42f6cfd99eb7615764d2e24
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M backends/send-uucp.in
M contrib/stathist.in
M contrib/tunefeed.in
M control/controlchan.in
M control/perl-nocem.in
M frontends/mailpost.in
M perl/INN/ovsqlite_client.pm
Log Message:
-----------
Remove spaces before parentheses in sub signatures
Homogenize the style, and also add early prototypes to satisfy "perl
warnings".
Commit: 34f912aa18daeb25fea7524ac92e7ddfda0c2c30
https://github.com/InterNetNews/inn/commit/34f912aa18daeb25fea7524ac92e7ddfda0c2c30
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M Makefile
M contrib/authmysql.in
M perl/INN/ovsqlite_client.pm
M scripts/innreport.in
Log Message:
-----------
Fix mismatched return warnings in some Perl code
Found by "perltidy --warn-mismatched-returns".
Commit: c77757972b69aeeb28572af396b61f41780561f5
https://github.com/InterNetNews/inn/commit/c77757972b69aeeb28572af396b61f41780561f5
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M backends/news2mail.in
M contrib/archivegz.in
M control/controlchan.in
M control/modules/newgroup.pl
M control/modules/rmgroup.pl
M control/perl-nocem.in
M frontends/cnfsheadconf.in
M frontends/cnfsstat.in
M frontends/scanspool.in
M perl/INN/Config.pm.in
M scripts/innreport.in
M storage/ovsqlite/ovsqlite-util.in
Log Message:
-----------
Better formatting of Perl code
Run perltidy without "-boc" and then re-apply "-boc".
Commit: a4b837120be3f3f93a515611e5e19afa88a30cca
https://github.com/InterNetNews/inn/commit/a4b837120be3f3f93a515611e5e19afa88a30cca
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M doc/pod/innd.pod
Log Message:
-----------
Remove stripping IP options from innd manual
A bug about stripping IP options not working for IPv6 connections was
mentioned in the innd manual page.
Stripping IP options for IPv4 was a vestige introduced in INN 1.6b1
and already removed in INN 2.6.0 in 2014 when modernizing the network
library.
Anyway, even the initial code from INN 1.6b1 was incomplete and did
not prevent INN from being vulnerable to IP spoofing attacks with
source-routed TCP connections.
Other software that also does IP-based restrictions never bothers with
this: xinetd, for example, or the rsync server. That implies that this
is no longer considered a significant security issue, probably because
it's been fixed upstream in the kernel network stack.
close #183
(more information in the ticket)
Commit: 83fe163b9357a36827aeb16d23cadc86c9fca578
https://github.com/InterNetNews/inn/commit/83fe163b9357a36827aeb16d23cadc86c9fca578
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M doc/pod/news.pod
M scripts/innreport_inn.pm
Log Message:
-----------
innreport: Better readership stats by domain
The current code only removes the first component
of the domain, which is not enough in some cases like
"ec2-13-236-155-204.ap-southeast-2.compute.amazonaws.com" and
"ec2-18-184-57-186.eu-central-1.compute.amazonaws.com" which would end
up in several lines gathered by AWS datacenters whereas we would just
want a report of AWS connections from "*.compute.amazonaws.com".
To improve the report, just keep up to the last 3 components of the
hostname. (Some country code top-level domains have 2 components, like
".co.uk" so we need a minimum of 3 components, which looks fine during
my testings.)
Also, add code to correctly report IPv6 addresses as unresolved instead
of unknown.
close #305
Commit: 208a8b3289a6040fb6c4bbe7c7353e257191730f
https://github.com/InterNetNews/inn/commit/208a8b3289a6040fb6c4bbe7c7353e257191730f
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M doc/pod/news.pod
M scripts/innreport-display.conf
Log Message:
-----------
innreport: Defaults to top 100 for nnrpd stats
Also improve (a bit) the name of the sections. Notably, the stats by
domain are for all the connections and not only readership connections
(that is to say which are not "curious" connections, reported
afterwards, without any NNTP command related to reading or posting).
Commit: 94075f9eb50f100687bba8aeac2a6f9080b85375
https://github.com/InterNetNews/inn/commit/94075f9eb50f100687bba8aeac2a6f9080b85375
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M doc/pod/news.pod
M scripts/innreport_inn.pm
Log Message:
-----------
innreport: Fix the totals in readership stats
Elapsed times, read articles and groups, etc. were wrong in totals.
When innreport tags a reader as a curious one (that is to say a
connection which does not send NNTP commands for reading nor posting)
or finds out that the client did not manage to authenticate, it was
removed from the readership statistics by client but is still counted
in the statistics per domain. Now fixed.
Also remove some unused variables while refactoring the related code.
close #306
Commit: c3c89de3e1587b7bb7ba8ed009876b591acf360c
https://github.com/InterNetNews/inn/commit/c3c89de3e1587b7bb7ba8ed009876b591acf360c
Author: Bo Lindbergh <2bfjdsla52kztwejndzdstsxl9athp at gmail.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M storage/ovsqlite/ovsqlite-util.in
Log Message:
-----------
ovsqlite-util: Remove useless check on a return
It doesn't seem to be explicitly stated in the current DBI
documentation, but the RaiseError attribute passed to the connect
method applies to that method call itself as well as to future method
calls on the returned database handle. So, with RaiseError => 1,
there's no need to check the return value.
This behaviour has been present since DBI version 0.91 released in
1997.
Commit: 37e29011fe7c5e8f0cc9662f7701820c56b8ff88
https://github.com/InterNetNews/inn/commit/37e29011fe7c5e8f0cc9662f7701820c56b8ff88
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M Makefile
Log Message:
-----------
Add perltidy check for unused constants
Commit: 8befd840b03323844b4d69272ab5f3e2b0942e77
https://github.com/InterNetNews/inn/commit/8befd840b03323844b4d69272ab5f3e2b0942e77
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M Makefile
Log Message:
-----------
Makefile: Fix the &> redirect bashism
Commit: af6550849a5b2c88a309a8366298b5f8b15c344c
https://github.com/InterNetNews/inn/commit/af6550849a5b2c88a309a8366298b5f8b15c344c
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
A .perlcriticrc
M MANIFEST
M Makefile
M doc/pod/hacking.pod
Log Message:
-----------
Check code with perlcritic
New .perlcriticrc configuration file, enabling checks for policies of
severity 5. Other policies will be eventually added.
Added perlcritic to the programs run by "make code-check".
Commit: c4e60415bd1ae81586ddd880b3b3267f0170f573
https://github.com/InterNetNews/inn/commit/c4e60415bd1ae81586ddd880b3b3267f0170f573
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M innd/perl.c
M lib/perl.c
M nnrpd/perl.c
Log Message:
-----------
Use SvPV_nolen instead of SvPV
SvPV_nolen was already available in Perl 5.8.0, and is more efficient
than SvPV used with the global PL_na variable as an argument because
PL_na must be accessed in thread-local storage in threaded Perl.
Commit: 8ec3fac3420fe5fa01fcd7056c8e609d44465254
https://github.com/InterNetNews/inn/commit/8ec3fac3420fe5fa01fcd7056c8e609d44465254
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M lib/network-innbind.c
M support/getrra-c-util
Log Message:
-----------
Backport latest rra-c-util changes to innbind
A message to recall that is now displayed when the getrra-c-util tool
finds that network.[ch] has been modified upstream.
Commit: d368227a55ab5a6c452153df5b2ae30331936181
https://github.com/InterNetNews/inn/commit/d368227a55ab5a6c452153df5b2ae30331936181
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M perl/INN/Config.pm.in
M scripts/innshellvars.pl.in
Log Message:
-----------
Document the absence of strictures
Commit: 1843dbab7c666eb39322ae43ec0ddeaf0be42acf
https://github.com/InterNetNews/inn/commit/1843dbab7c666eb39322ae43ec0ddeaf0be42acf
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M contrib/archivegz.in
M contrib/tunefeed.in
M perl/INN/ovsqlite_client.pm
M scripts/innreport.in
Log Message:
-----------
Explicitly use return statements
In one call, only the first returned value is used.
Reported by "perltidy --warn-mismatched-return".
Commit: a72018c78ea562328138f66988eb5600bb57d2bd
https://github.com/InterNetNews/inn/commit/a72018c78ea562328138f66988eb5600bb57d2bd
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M contrib/archivegz.in
M control/controlchan.in
M scripts/innreport.in
M storage/ovsqlite/ovsqlite-util.in
Log Message:
-----------
Use bare return instead of return undef
To comply with the perlcritic Subroutines::ProhibitExplicitReturnUndef
policy.
Note that there's no bug in the current code as these return statements
were all in a scalar context.
Commit: 820702b7b3d2a7ca5037f37ef16558c56ad12821
https://github.com/InterNetNews/inn/commit/820702b7b3d2a7ca5037f37ef16558c56ad12821
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M contrib/archivegz.in
Log Message:
-----------
contrib/archivegz: Create parent directories
The code was misplaced. Thanks, perlcritic!
Commit: bfeea923e38460d0d2d3a957a68d2a4c6b359e54
https://github.com/InterNetNews/inn/commit/bfeea923e38460d0d2d3a957a68d2a4c6b359e54
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M control/controlchan.in
Log Message:
-----------
controlchan: Explicitly name STDERR instead of 2
Commit: 81d51b43e2fd7b3e6c1e741dae4f7b2c3bdedb40
https://github.com/InterNetNews/inn/commit/81d51b43e2fd7b3e6c1e741dae4f7b2c3bdedb40
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M control/controlchan.in
Log Message:
-----------
Acknowledge old-school .pl libraries in require
To comply with the perlcritic Modules::RequireBarewordIncludes policy.
Commit: 85cf6ad84c251485a8e25c4873874a8e1b52178e
https://github.com/InterNetNews/inn/commit/85cf6ad84c251485a8e25c4873874a8e1b52178e
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M control/controlchan.in
M scripts/innreport.in
Log Message:
-----------
No longer use indirect object call syntax
To comply with the perlcritic Objects::ProhibitIndirectSyntax policy.
Commit: 7a540e14bd162dc9074df505beb7b5c240be5d4a
https://github.com/InterNetNews/inn/commit/7a540e14bd162dc9074df505beb7b5c240be5d4a
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M control/controlchan.in
M frontends/cnfsstat.in
M frontends/pullnews.in
M scripts/innreport.in
Log Message:
-----------
Don't declare variables with a postfix conditional
To comply with the perlcritic
Variables::ProhibitConditionalDeclarations policy.
Commit: 72584e1f02ca7d27524105e6498f458711e8d902
https://github.com/InterNetNews/inn/commit/72584e1f02ca7d27524105e6498f458711e8d902
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M innfeed/testListener.pl
M tests/clients/server-list.in
Log Message:
-----------
Acknowledge select for non-integer sleeps
To comply with the perlcritic BuiltinFunctions::ProhibitSleepViaSelect
policy. Time::HiRes might not be available, and we only use the
construct in test programs anyway.
Commit: c2635d0860c71f11b8ba7d80d6df1455b973a1ce
https://github.com/InterNetNews/inn/commit/c2635d0860c71f11b8ba7d80d6df1455b973a1ce
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M contrib/archivegz.in
M contrib/cleannewsgroups.in
M contrib/count_overview.in
M contrib/findreadgroups.in
M contrib/makeexpctl.in
M contrib/makestorconf.in
M contrib/thdexpire.in
M innfeed/testListener.pl
M scripts/innreport_inn.pm
M tests/clients/server-list.in
Log Message:
-----------
Disambiguate the local use of variables in loops
To comply with the perlcritic Variables::RequireLexicalLoopIterators
policy.
Commit: ae4aec48d469c0d8b5cccf7d17499a1858a0dcc5
https://github.com/InterNetNews/inn/commit/ae4aec48d469c0d8b5cccf7d17499a1858a0dcc5
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M contrib/thdexpire.in
M scripts/inncheck.in
M scripts/innupgrade.in
Log Message:
-----------
Acknowledge the use of octal numbers in Perl code
To comply with the perlcritic
ValuesAndExpressions::ProhibitLeadingZeros policy.
Commit: c3074c4d032ce5f755c7374640148679bd98668f
https://github.com/InterNetNews/inn/commit/c3074c4d032ce5f755c7374640148679bd98668f
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M contrib/analyze-traffic.in
M contrib/backlogstat.in
M contrib/tunefeed.in
M frontends/pullnews.in
M perl/INN/ovsqlite_client.pm
M samples/startup_innd.pl
M tests/clients/server-list.in
Log Message:
-----------
Declare strictures before any other statements
To comply with the perlcritic TestingAndDebugging::RequireUseStrict
policy.
Commit: f20319e0b0d26b2af4b30e9329bc78dabf17ecf6
https://github.com/InterNetNews/inn/commit/f20319e0b0d26b2af4b30e9329bc78dabf17ecf6
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M control/perl-nocem.in
Log Message:
-----------
perl-nocem: Bare return instead of return undef
To comply with the perlcritic Subroutines::ProhibitExplicitReturnUndef
policy.
Note that there's no bug in the current code as these return statements
were all in a scalar context.
Commit: 84fc66e1c3f62987b20c1f358b75aa167223e64d
https://github.com/InterNetNews/inn/commit/84fc66e1c3f62987b20c1f358b75aa167223e64d
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M .gitignore
M MANIFEST
M support/mkmanifest
M tests/Makefile
M tests/TESTS
A tests/perl/minimum-version.t.in
Log Message:
-----------
Add new test to check the minimum Perl version
Make use of the Test::MinimumVersion Perl module.
The good news is that all the tests pass fine with 5.006.
Commit: 6ba0e20ed072bc5a47db67e4ebe7e2730cc9f55d
https://github.com/InterNetNews/inn/commit/6ba0e20ed072bc5a47db67e4ebe7e2730cc9f55d
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M configure.ac
Log Message:
-----------
configure: Check Perl 5.006 instead of 5.004_03
We already recommended the use of Perl 5.008 in our documentation.
Some Perl scripts require 5.006 so let's check for this version.
Commit: 5214135b029d7a6eb5e4d4f322752c6fb34fda0e
https://github.com/InterNetNews/inn/commit/5214135b029d7a6eb5e4d4f322752c6fb34fda0e
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M support/getc-tap-harness
M tests/docs/pod.t.in
Log Message:
-----------
docs/pod.t: Fix comments and upstream package
Commit: 0de2bba087a3de383bc066ef03fd7864f8261869
https://github.com/InterNetNews/inn/commit/0de2bba087a3de383bc066ef03fd7864f8261869
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M ci/apt-packages
Log Message:
-----------
Install Test::MinimumVersion on GitHub CI
Commit: 03d2e51f29edab2db9ac6fcf35ce20d3e4393000
https://github.com/InterNetNews/inn/commit/03d2e51f29edab2db9ac6fcf35ce20d3e4393000
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M .perlcriticrc
M perl/INN/Config.pm.in
Log Message:
-----------
Enable strictures on INN::Config
Commit: b91bb73bab932ed15cb59efda1f1a0be357fb266
https://github.com/InterNetNews/inn/commit/b91bb73bab932ed15cb59efda1f1a0be357fb266
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M backends/send-uucp.in
M frontends/mailpost.in
M frontends/pullnews.in
M scripts/inncheck.in
Log Message:
-----------
Use blocks in Perl grep functions
To comply with the perlcritic BuiltinFunctions::RequireBlockGrep
policy.
Commit: 5d6909df2252b7424fbca57f9531f165bf73a38b
https://github.com/InterNetNews/inn/commit/5d6909df2252b7424fbca57f9531f165bf73a38b
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M .perlcriticrc
Log Message:
-----------
Exclude freenode theme from perlcritic
Commit: 75c5b29457ce3ba4ab1cc003590f3299f43ff6c6
https://github.com/InterNetNews/inn/commit/75c5b29457ce3ba4ab1cc003590f3299f43ff6c6
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M storage/buildconfig.in
M storage/ovsqlite/sqlite-helper-gen.in
Log Message:
-----------
Use blocks in Perl map functions
To comply with the perlcritic BuiltinFunctions::RequireBlockMap
policy.
Commit: c8bf5309ff1e6ba9da9892bd0af53ad6d3ef1e68
https://github.com/InterNetNews/inn/commit/c8bf5309ff1e6ba9da9892bd0af53ad6d3ef1e68
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M .perlcriticrc
M frontends/cnfsstat.in
Log Message:
-----------
Don't use $a or $b as variable names outside sort
To comply with the perlcritic Community::DollarAB policy.
Commit: 2ff23bcd87cc123a7b24f534ea08c2eb74142f1c
https://github.com/InterNetNews/inn/commit/2ff23bcd87cc123a7b24f534ea08c2eb74142f1c
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M control/controlchan.in
Log Message:
-----------
controlchan: Fix nit in a loop on the whole hash
To comply with the perlcritic Community::LoopOnHash policy.
Commit: 55ebc3172aa8d02ae46b86890622a8f1ba4382bc
https://github.com/InterNetNews/inn/commit/55ebc3172aa8d02ae46b86890622a8f1ba4382bc
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M .perlcriticrc
M backends/mod-active.in
M backends/news2mail.in
M backends/send-uucp.in
M backends/sendinpaths.in
M contrib/analyze-traffic.in
M contrib/authmysql.in
M contrib/cleannewsgroups.in
M contrib/findreadgroups.in
M contrib/makeexpctl.in
M contrib/makestorconf.in
M contrib/nnrp.access2readers.conf.in
M contrib/stathist.in
M contrib/thdexpire.in
M control/controlchan.in
M control/modules/checkgroups.pl
M control/modules/ihave.pl
M control/modules/newgroup.pl
M control/modules/rmgroup.pl
M control/modules/sendme.pl
M control/perl-nocem.in
M frontends/cnfsheadconf.in
M frontends/cnfsstat.in
M frontends/mailpost.in
M frontends/pullnews.in
M frontends/scanspool.in
M innfeed/procbatch.in
M samples/nnrpd_access.pl.in
M samples/nnrpd_auth.pl.in
M scripts/inncheck.in
M scripts/innmail.in
M scripts/innupgrade.in
M scripts/simpleftp.in
M storage/ovsqlite/ovsqlite-util.in
M support/mkmanifest
M tests/clients/server-list.in
Log Message:
-----------
Add "use warnings" in addition to "perl -w"
Most of our programs were already running with warnings on,
as "perl -w" was in the shebang. Let's explicitly mention it.
To comply with the perlcritic TestingAndDebugging::RequireUseWarnings
policy.
Commit: c4f541f4a8010b414c0031d71efd208e02af777a
https://github.com/InterNetNews/inn/commit/c4f541f4a8010b414c0031d71efd208e02af777a
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M samples/filter_innd.pl
M samples/filter_nnrpd.pl
M samples/startup_innd.pl
Log Message:
-----------
End filter hooks with 1
To comply with the perlcritic Modules::RequireEndWithOne
policy.
Commit: 0cbe4709bafc4c8266f6d9be71229737e629bdda
https://github.com/InterNetNews/inn/commit/0cbe4709bafc4c8266f6d9be71229737e629bdda
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M contrib/ovsqlite-dump.in
M frontends/pullnews.in
M perl/INN/ovsqlite_client.pm
M scripts/inncheck.in
M scripts/innreport.in
M storage/ovsqlite/ovsqlite-util.in
Log Message:
-----------
Disambiguate mixed low / high-precedence operators
Better readibility.
To comply with the perlcritic
ValuesAndExpressions::ProhibitMixedBooleanOperators policy.
Commit: 99993423aeaf6c6ab81bbba1545504c5cfe43f02
https://github.com/InterNetNews/inn/commit/99993423aeaf6c6ab81bbba1545504c5cfe43f02
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M contrib/count_overview.in
Log Message:
-----------
count_overview: Use negative array indexes
To comply with the perlcritic Variables::RequireNegativeIndices
policy.
Commit: 3912bcb7ab1be623ad2f8f572e942122e546f74b
https://github.com/InterNetNews/inn/commit/3912bcb7ab1be623ad2f8f572e942122e546f74b
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M .perlcriticrc
M scripts/innshellvars.pl.in
Log Message:
-----------
Reviewed perlcritic policies of severity 4
Commit: c478765d16e28fa70c28de80671855d8c1404f02
https://github.com/InterNetNews/inn/commit/c478765d16e28fa70c28de80671855d8c1404f02
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M contrib/cleannewsgroups.in
M contrib/thdexpire.in
M contrib/tunefeed.in
M scripts/innreport.in
M tests/clients/server-list.in
Log Message:
-----------
Improve readability of negated unless
To comply with the perlcritic
ControlStructures::ProhibitNegativeExpressionsInUnlessAndUntilConditions
policy.
Commit: 675b2b37c3893dd3e1510cf05ad1ab57dca63a6e
https://github.com/InterNetNews/inn/commit/675b2b37c3893dd3e1510cf05ad1ab57dca63a6e
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M control/perl-nocem.in
M frontends/pullnews.in
Log Message:
-----------
Acknowledge the use of conditional use statements
To comply with the perlcritic Modules::ProhibitConditionalUseStatements
policy.
Commit: d1c48f3cec210128e78a0c97fa53b8798129d990
https://github.com/InterNetNews/inn/commit/d1c48f3cec210128e78a0c97fa53b8798129d990
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M .perlcriticrc
M backends/mod-active.in
Log Message:
-----------
Acknowledge the use of backtick operators
Check for them only in void context.
To comply with the perlcritic InputOutput::ProhibitBacktickOperators
policy.
Commit: 3bf93e32597f574091de3d2b82fd99a1d95618a1
https://github.com/InterNetNews/inn/commit/3bf93e32597f574091de3d2b82fd99a1d95618a1
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M backends/sendinpaths.in
Log Message:
-----------
Add a comment in an empty loop
To comply with the perlcritic
ValuesAndExpressions::ProhibitNullStatements policy.
Commit: fc6bbf2569451464a11135c32afdd0e0776b8f2d
https://github.com/InterNetNews/inn/commit/fc6bbf2569451464a11135c32afdd0e0776b8f2d
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M contrib/nnrp.access2readers.conf.in
Log Message:
-----------
Don't use special literals as a heredoc terminator
To comply with the perlcritic
ValuesAndExpressions::ProhibitSpecialLiteralHeredocTerminator policy.
Commit: de922a0a57facce9c13d8ef07110891b3416637a
https://github.com/InterNetNews/inn/commit/de922a0a57facce9c13d8ef07110891b3416637a
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M contrib/authmysql.in
M frontends/pullnews.in
M history/buildconfig.in
M scripts/inncheck.in
M storage/buildconfig.in
Log Message:
-----------
Remove useless backslashes
Better readibility.
To comply with the perlcritic
ValuesAndExpressions::ProhibitUnknownBackslash policy.
Commit: 4b0d1b32cf488345caf02303583a4f9e073f01e5
https://github.com/InterNetNews/inn/commit/4b0d1b32cf488345caf02303583a4f9e073f01e5
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M control/perl-nocem.in
Log Message:
-----------
perl-nocem: Add missing backslashes
The backslashes were really meant to be output as-is.
Commit: 0f41cd537d2f337612e2b9598ce31c0f3f338ae8
https://github.com/InterNetNews/inn/commit/0f41cd537d2f337612e2b9598ce31c0f3f338ae8
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M control/modules/checkgroups.pl
M control/modules/newgroup.pl
M control/modules/rmgroup.pl
M scripts/innreport.in
Log Message:
-----------
Double-quote heredoc terminators
Better readibility.
To comply with the perlcritic
ValuesAndExpressions::RequireQuotedHeredocTerminator policy.
Commit: 2aa2e26f91763712f9d49db686dd353997f96824
https://github.com/InterNetNews/inn/commit/2aa2e26f91763712f9d49db686dd353997f96824
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M .perlcriticrc
Log Message:
-----------
Reviewed perlcritic policies of severity 3
Commit: 3c3a08cec0774bacec82c8a995bbd152f3f75f26
https://github.com/InterNetNews/inn/commit/3c3a08cec0774bacec82c8a995bbd152f3f75f26
Author: Christian Clauss <cclauss at me.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M LICENSE
Log Message:
-----------
LICENSE: Fix typo -- prominently
Commit: 6728afa095b0714645d52ff06d5810273b1c5c12
https://github.com/InterNetNews/inn/commit/6728afa095b0714645d52ff06d5810273b1c5c12
Author: Christian Clauss <cclauss at me.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M CONTRIBUTORS
M MANIFEST
M authprogs/ckpasswd.c
M backends/innxmit.c
M backends/overchan.c
M contrib/README
M contrib/analyze-traffic.in
M contrib/auth_pass.README
M contrib/innconfcheck.in
M contrib/makeexpctl.in
M control/pgpverify.in
M doc/FAQ
M doc/config-semantics
M doc/history
M doc/history-innfeed
M expire/fastrm.c
M frontends/encode.c
M frontends/ovdb_stat.c
M frontends/rnews.c
M include/inn/innconf.h
M include/inn/tst.h
M innd/README
M innd/art.c
M innd/innd.h
M innd/nc.c
M innd/util.c
M innd/wip.c
M innfeed/article.c
M innfeed/article.h
M innfeed/buffer.h
M innfeed/connection.c
M innfeed/connection.h
M innfeed/endpoint.c
M innfeed/endpoint.h
M innfeed/imap_connection.c
M innfeed/innlistener.c
M innfeed/innlistener.h
M innfeed/main.c
M lib/confparse.c
M lib/date.c
M lib/dbz.c
M lib/md5.c
M lib/nntp.c
M lib/tst.c
M m4/libtool.m4
M nnrpd/article.c
M nnrpd/nnrpd.c
M nnrpd/perl.c
M nnrpd/tls.c
M samples/filter_innd.pl
M scripts/innreport.in
M scripts/innreport_inn.pm
M scripts/innshellvars.pl.in
M site/Makefile
M storage/cnfs/cnfs.c
M storage/timecaf/README.CAF
M storage/timecaf/caf.c
M storage/tradspool/tradspool.c
M tests/lib/canlock-t.c
M tests/lib/confparse-t.c
M tests/storage/archive.t
Log Message:
-----------
Fix typos discovered by codespell
Commit: b09630a7753984a2a0fef3f1536c3ff4342516d4
https://github.com/InterNetNews/inn/commit/b09630a7753984a2a0fef3f1536c3ff4342516d4
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M CONTRIBUTORS
Log Message:
-----------
Add Christian Clauss to CONTRIBUTORS
Commit: 98845dfe758a83f004bdd9b6cde92ccf99ffc8bd
https://github.com/InterNetNews/inn/commit/98845dfe758a83f004bdd9b6cde92ccf99ffc8bd
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M contrib/authmysql.in
M contrib/fixhist.in
M control/perl-nocem.in
M frontends/pullnews.in
M frontends/scanspool.in
Log Message:
-----------
Use regexp with Perl script builtin
To comply with the perlcritic BuiltinFunctions::ProhibitStringySplit
policy.
Commit: 4c08ee72e448d120aef5874d45b15e1cc681413b
https://github.com/InterNetNews/inn/commit/4c08ee72e448d120aef5874d45b15e1cc681413b
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M backends/sendinpaths.in
M scripts/inncheck.in
Log Message:
-----------
Use qw() instead of explicit lists
To comply with the perlcritic CodeLayout::ProhibitQuotedWordLists
policy.
Commit: 089531e7753875f849afe1456714f6074f63b6c8
https://github.com/InterNetNews/inn/commit/089531e7753875f849afe1456714f6074f63b6c8
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M contrib/analyze-traffic.in
M contrib/nnrp.access2readers.conf.in
M scripts/innreport.in
Log Message:
-----------
Acknowledge the proper use of each builtin
Make the Perl::Critic::Policy::Community::Each policy happy.
Commit: b82371f63dc0bf60a76f674aab62d370633cb1bf
https://github.com/InterNetNews/inn/commit/b82371f63dc0bf60a76f674aab62d370633cb1bf
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M backends/delayer.in
M backends/mod-active.in
M backends/news2mail.in
M backends/send-uucp.in
M backends/sendinpaths.in
M contrib/analyze-traffic.in
M contrib/authmysql.in
M contrib/backlogstat.in
M contrib/cleannewsgroups.in
M contrib/findreadgroups.in
M contrib/makeexpctl.in
M contrib/makestorconf.in
M contrib/nnrp.access2readers.conf.in
M contrib/ovsqlite-dump.in
M contrib/ovsqlite-undump.in
M contrib/stathist.in
M contrib/thdexpire.in
M control/controlchan.in
M control/perl-nocem.in
M frontends/cnfsheadconf.in
M frontends/cnfsstat.in
M frontends/mailpost.in
M frontends/pullnews.in
M frontends/scanspool.in
M innfeed/procbatch.in
M perl/INN/Utils/Shlock.pm.in
M samples/nnrpd_access.pl.in
M samples/nnrpd_auth.pl.in
M scripts/inncheck.in
M scripts/innmail.in
M scripts/innupgrade.in
M scripts/simpleftp.in
M storage/ovsqlite/ovsqlite-util.in
M support/mkmanifest
M tests/clients/server-list.in
Log Message:
-----------
Remove useless Perl warning switches in shebang
We already have "use warnings".
The -w switch enables warnings globally in the program, including for
any modules that did not explicitly enable or disable any warnings.
To comply with the perlcritic
Perl::Critic::Policy::Community::WarningsSwitch policy.
Commit: 6054b986d278ba3b3bd1c20252481a691f9154bc
https://github.com/InterNetNews/inn/commit/6054b986d278ba3b3bd1c20252481a691f9154bc
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M .perlcriticrc
M configure.ac
M perl/INN/ovsqlite_client.pm
Log Message:
-----------
Mention that INN::ovsqlite_client needs Perl 5.8.0
Commit: 598072e2ed1b407f12f308d78b8c01d2655989c9
https://github.com/InterNetNews/inn/commit/598072e2ed1b407f12f308d78b8c01d2655989c9
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M frontends/mailpost.in
Log Message:
-----------
Use File::Spec for /dev/null
To comply with the perlcritic Compatibility::ProhibitUnixDevNull
policy.
Commit: 0be61ef19691ef63002fc25d5be03cfa1aa053fa
https://github.com/InterNetNews/inn/commit/0be61ef19691ef63002fc25d5be03cfa1aa053fa
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M contrib/tunefeed.in
M frontends/mailpost.in
Log Message:
-----------
Typo fix (missing parenthesis)
Also add a SEE ALSO section, and __END__.
Found by the Documentation::ProhibitUnbalancedParens,
Documentation::RequireEndBeforeLastPod and
Documentation::RequirePodSections perlcritic policies.
Commit: 638391a20fde833d6290239b71c5d069381d1e50
https://github.com/InterNetNews/inn/commit/638391a20fde833d6290239b71c5d069381d1e50
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M tests/perl/minimum-version.t.in
Log Message:
-----------
Fix the test suite for minimum Perl version
INN::ovsqlite_client needs Perl 5.8.0 and must therefore be declared
accordingly in the test suite.
Commit: 33f1645313ad16bc3d5e3f037cf0159da8c1d863
https://github.com/InterNetNews/inn/commit/33f1645313ad16bc3d5e3f037cf0159da8c1d863
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M .perlcriticrc
M configure.ac
M doc/pod/controlchan.pod
M doc/pod/hacking.pod
M doc/pod/install.pod
M readme.pod
Log Message:
-----------
Remove obsolete wording about Perl prior to 5.6.0
Simplify the reading of the documentation.
Commit: 0b8b7db4f5b7acb1ee19c1ffcac3779c3bfd8139
https://github.com/InterNetNews/inn/commit/0b8b7db4f5b7acb1ee19c1ffcac3779c3bfd8139
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M contrib/analyze-traffic.in
M scripts/innreport.in
M scripts/innshellvars.pl.in
M tests/docs/pod.t.in
Log Message:
-----------
Update current uses and syntax of no critic
Commit: 6bdbe5f3b53fd560243e04aa20e9533e4fdf09e4
https://github.com/InterNetNews/inn/commit/6bdbe5f3b53fd560243e04aa20e9533e4fdf09e4
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M contrib/archivegz.in
M contrib/makeexpctl.in
M innfeed/testListener.pl
M storage/ovsqlite/ovsqlite-util.in
Log Message:
-----------
Use my instead of local for local variables
To comply with the perlcritic Variables::ProhibitLocalVars policy.
Commit: b64fc466ee4e293551f18f5a9cdddccbb843f9b0
https://github.com/InterNetNews/inn/commit/b64fc466ee4e293551f18f5a9cdddccbb843f9b0
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M doc/pod/innfeed.pod
M doc/pod/libinn_qio.pod
Log Message:
-----------
Typos in POD documentation
Commit: 895136fd209f00c1461843279fd0c00f49b9895a
https://github.com/InterNetNews/inn/commit/895136fd209f00c1461843279fd0c00f49b9895a
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M .perlcriticrc
M frontends/cnfsstat.in
Log Message:
-----------
Reviewed perlcritic policies of severity 2
Commit: 9fde3f35bdd645c4a58a4aaae3c6c6e3ea97564f
https://github.com/InterNetNews/inn/commit/9fde3f35bdd645c4a58a4aaae3c6c6e3ea97564f
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M scripts/innreport.in
M scripts/innreport_inn.pm
Log Message:
-----------
innreport: Prefer the use of revert sort
To comply with the perlcritic
BuiltinFunctions::ProhibitReverseSortBlock policy.
Commit: bec358afbf1ee53fee250bb700cbf878f403633e
https://github.com/InterNetNews/inn/commit/bec358afbf1ee53fee250bb700cbf878f403633e
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M contrib/thdexpire.in
Log Message:
-----------
thdexpire: Move POD documentation at the end
To comply with the perlcritic Documentation::RequirePodAtEnd policy.
It is also already the style of our other programs.
Commit: 649cda711349c8fac11c0e4083186e9d1141ddf4
https://github.com/InterNetNews/inn/commit/649cda711349c8fac11c0e4083186e9d1141ddf4
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M contrib/ovsqlite-dump.in
M contrib/ovsqlite-undump.in
M perl/INN/ovsqlite_client.pm
Log Message:
-----------
Remove useless bareword double colons
To comply with the perlcritic
ValuesAndExpressions::ProhibitBarewordDoubleColon policy.
Commit: 0e15fee8c39e142c8399dd70f8c980fcb0f2f5ea
https://github.com/InterNetNews/inn/commit/0e15fee8c39e142c8399dd70f8c980fcb0f2f5ea
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M control/perl-nocem.in
M scripts/innreport.in
M storage/ovsqlite/ovsqlite-util.in
Log Message:
-----------
Recognize locale_h import and a char alternation
To comply with the perlcritic TooMuchCode::ProhibitUnusedImport and
RegularExpressions::ProhibitSingleCharAlternation policies.
Commit: 3abfa878c1bca8b193e929d4d213e82e4eefd42d
https://github.com/InterNetNews/inn/commit/3abfa878c1bca8b193e929d4d213e82e4eefd42d
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M .perlcriticrc
Log Message:
-----------
Reviewed perlcritic policies of severity 1
Commit: 95243e606a95d860590f80402dc54069fac6aca1
https://github.com/InterNetNews/inn/commit/95243e606a95d860590f80402dc54069fac6aca1
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M .perlcriticrc
M .perltidyrc
M contrib/authmysql.in
M control/perl-nocem.in
M doc/pod/hook-perl.pod
M perl/INN/Utils/Shlock.pm.in
M perl/INN/ovsqlite_client.pm
M scripts/inncheck.in
M storage/ovsqlite/ovsqlite-util.in
Log Message:
-----------
Add missing trailing commas in Perl code
The latest perltidy release improved the addition of trailing commas
and their stability. Let's enforce them now, in compliance with the
CodeLayout::RequireTrailingCommaAtNewline perlcritic policy.
Commit: 6b7472f7fed25f994b01a9e076ebb41bfff2b6dc
https://github.com/InterNetNews/inn/commit/6b7472f7fed25f994b01a9e076ebb41bfff2b6dc
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M .perltidyrc
M contrib/ovsqlite-dump.in
M contrib/tunefeed.in
M control/controlchan.in
M control/perl-nocem.in
M frontends/mailpost.in
M frontends/pullnews.in
M history/buildconfig.in
M perl/INN/Config.pm.in
M perl/INN/ovsqlite_client.pm
M scripts/inncheck.in
M scripts/innreport.in
M storage/buildconfig.in
Log Message:
-----------
Improve the formatting of Perl qw lists
Use new perltidy --qw-as-function option.
Commit: 13a691093e2f08d878534738f2b2abfbcbc04ffb
https://github.com/InterNetNews/inn/commit/13a691093e2f08d878534738f2b2abfbcbc04ffb
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M contrib/authmysql.in
M doc/pod/hook-perl.pod
M frontends/pullnews.in
M scripts/inncheck.in
Log Message:
-----------
Improve some formatting
Commit: 0ce29b43646fc0334bf50bf6535118b727739aea
https://github.com/InterNetNews/inn/commit/0ce29b43646fc0334bf50bf6535118b727739aea
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M samples/filter_innd.pl
M samples/filter_nnrpd.pl
Log Message:
-----------
Proof-read Perl hook samples
Better formatting, mention "shutdown" as a possible NewMode, fix typos
in Perl code, list all the standard header fields.
Commit: 7f6986443d3e5e28fab6237898c68c75ba2be393
https://github.com/InterNetNews/inn/commit/7f6986443d3e5e28fab6237898c68c75ba2be393
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M doc/pod/inn.conf.pod
M expire/makehistory.c
M frontends/inews.c
M include/inn/paths.h.in
M innd/cc.c
M innd/chan.c
M innd/python.c
M innd/rc.c
M lib/innconf.c
M nnrpd/python.c
M storage/tradindexed/tdx-util.c
Log Message:
-----------
Refactor in paths.in all the environment variables
Commit: 44ecd92af7846a137938679b1ddc711a2a3139cf
https://github.com/InterNetNews/inn/commit/44ecd92af7846a137938679b1ddc711a2a3139cf
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M doc/pod/install.pod
M readme.pod
Log Message:
-----------
Mention Docker images in README and INSTALL
Add a link to 2 projects.
see #311
Commit: cc3269906b260a04262adc8464f55c76e5c3c501
https://github.com/InterNetNews/inn/commit/cc3269906b260a04262adc8464f55c76e5c3c501
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M doc/pod/inn.conf.pod
M doc/pod/libinn.pod
M doc/pod/news.pod
M include/inn/paths.h.in
M lib/Makefile
M lib/getfqdn.c
M lib/innconf.c
Log Message:
-----------
Do not bail when a FQDN is not found
Improve how the check works at startup:
- recognize an INN_HOSTNAME environment variable that, when set and
fully qualified, is taken by INN as the hostname;
- make non-fatal the check for a fully qualified hostname. This way,
the warning appears in the logs, and the news admin will see it and
can take appropriate actions. The installation of INN will no longer
fail when using the Debian package (and probably also from other
distributions) on Docker.
The second point is normally enough to solve the issue of this ticket.
The environment variable permits silencing the warning.
close #311
Commit: 8fa5de2d48c87ab89fbe5a04f9d4f7bbf0a06b8e
https://github.com/InterNetNews/inn/commit/8fa5de2d48c87ab89fbe5a04f9d4f7bbf0a06b8e
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M doc/pod/news.pod
Log Message:
-----------
Update NEWS with perlcritic and codespell work
Commit: 5d6bb16de257332bb9d5e227091e976e891ba896
https://github.com/InterNetNews/inn/commit/5d6bb16de257332bb9d5e227091e976e891ba896
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M contrib/README
M doc/FAQ
M doc/pod/checklist.pod
M doc/pod/hacking.pod
M doc/pod/install.pod
M doc/pod/moderators.pod
M doc/pod/newsgroups.pod
M doc/pod/simpleftp.pod
Log Message:
-----------
Use downloads.isc.org in documentation
This is the preferred name for the ftp.isc.org server in https.
see #312
Commit: 1ad84c45585a0354672766e5965e9de8d4898c6d
https://github.com/InterNetNews/inn/commit/1ad84c45585a0354672766e5965e9de8d4898c6d
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M doc/pod/simpleftp.pod
M scripts/simpleftp.in
Log Message:
-----------
simpleftp: Add debug mode, passive mode, timeout
Commit: d0c233b730196cf24ece82ef73287e544e935a46
https://github.com/InterNetNews/inn/commit/d0c233b730196cf24ece82ef73287e544e935a46
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M doc/pod/news.pod
M scripts/simpleftp.in
Log Message:
-----------
simpleftp: Fix the parsing of port numbers
host and port were reversed. Also prevent IPv6 addresses from being
parsed.
Commit: c50ef32b8ff7533d0d22bed430d801e74307b960
https://github.com/InterNetNews/inn/commit/c50ef32b8ff7533d0d22bed430d801e74307b960
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M backends/actsyncd.in
M doc/pod/actsync.pod
M doc/pod/news.pod
Log Message:
-----------
actsyncd: Add bzip2 support
Commit: 22e278aedf2e7616e33fa003365d34d16a65e875
https://github.com/InterNetNews/inn/commit/22e278aedf2e7616e33fa003365d34d16a65e875
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M backends/actsyncd.in
M doc/pod/actsync.pod
Log Message:
-----------
actsyncd: Clean up and a few fixes
- Typo in $ign variable instead of $cfg.
- Improve comments, remove dead code about "spool".
- Add the .gz and .Z extension (at least the navite uncompress program
expects .Z when gzip is not used as uncompress).
- $? is not the right status when used after a test condition (which
changes $? to the result of the test).
- Use the value of $loop instead of hard-coded 10.
- Better use "-n" instead of "! -z".
Commit: 80b3b60f8b702dac2996990c0d5f38625093e6cb
https://github.com/InterNetNews/inn/commit/80b3b60f8b702dac2996990c0d5f38625093e6cb
Author: Julien ÉLIE <Julien-Elie at users.noreply.github.com>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M backends/actsyncd.in
M configure.ac
M doc/pod/actsync.pod
M doc/pod/news.pod
M doc/pod/simpleftp.pod
M m4/compress.m4
M perl/INN/Config.pm.in
M samples/actsync.cfg
M samples/actsync.ign
M scripts/innshellvars.in
M scripts/innshellvars.pl.in
M scripts/innshellvars.tcl.in
M scripts/simpleftp.in
Log Message:
-----------
actsyncd, simpleftp: Add HTTP(S) support
actsyncd and simpleftp were only supporting the FTP and NNTP protocol
to synchronize from external sources. As support for FTP will soon be
discontinued for the ftp.isc.org service, in favour of HTTP(S), update
these programs to make use of these protocols.
New path and protocol keywords in actsync.cfg, keeping ftppath for
backwards-compatibility. New PATH_GETHTTP variable at configure time,
and $gethttp in innshellvars and INN::Config. Updated samples of
actsync.cfg and actsync.ign. Updated documentation.
Mention wget in the useful optional packages to install, at the
beginning of the configure output.
close #312
Compare: https://github.com/InterNetNews/inn/compare/b18bf27880c7...80b3b60f8b70
To unsubscribe from these emails, change your notification settings at https://github.com/InterNetNews/inn/settings/notifications
More information about the inn-committers
mailing list