minor bugfix in buffindexed.c

Richard Todd rmtodd at skywalker.ecn.ou.edu
Thu Dec 9 04:08:21 UTC 1999


The call to open() in buffindexed.c that creates group.index does so
with the wrong modes, because the call to open() doesn't include the
third argument (file modes), so the file gets created with whatever 
mode value happens to be on the stack. 
Index: storage/buffindexed//buffindexed.c
===================================================================
RCS file: /home/rmtodd/TempCVS/Temp-CVS-Repository/inn-current/storage/buffindexed/buffindexed.c,v
retrieving revision 1.1.1.17
diff -u -r1.1.1.17 buffindexed.c
--- buffindexed.c	1999/12/01 05:45:44	1.1.1.17
+++ buffindexed.c	1999/12/01 22:29:35
@@ -894,7 +894,7 @@
   if (Needunlink && unlink(groupfn) == 0) {
     syslog(L_NOTICE, "%s: all buffers are brandnew, unlink '%s'", LocalLogName, groupfn);
   }
-  GROUPfd = open(groupfn, ovbuffmode & OV_WRITE ? O_RDWR | O_CREAT : O_RDONLY);
+  GROUPfd = open(groupfn, ovbuffmode & OV_WRITE ? O_RDWR | O_CREAT : O_RDONLY, 0660);
   if (GROUPfd < 0) {
     syslog(L_FATAL, "%s: Could not create %s: %m", LocalLogName, groupfn);
     DISPOSE(groupfn);


More information about the inn-patches mailing list