innd's code cleanup

[Igor Timkin]

Matus "fantomas" Uhlar writes:
> -> With -pedantic (I use this option for test compile) gcc (2.95.2)
> -> type many warning about ``%m'' format in syslog calls.
> 
> may I se some?

buffindexed.c:1365: warning: ANSI C does not support the `m' format
buffindexed.c:1402: warning: ANSI C does not support the `m' format
buffindexed.c:1422: warning: ANSI C does not support the `m' format

> -> P.S. We need change -O2 optimization to -O (see inn-bugs). -O2 seems
> -> to broken for gcc2.95.2/x86 (or add comment about it to makefile).
> 
> What kind of OS do you have installed ? AFAIK Redhat made some changes in

FreeBSD. FreeBSD use -O with gcc2.95.2 and -O2 with old gcc (2.7.2.3).
I ran inn with -O3 with old gcc without problems.

> gcc that made it incompatible. Even if not, it's compiler what's broken, not
> the sources so we should avoid replacing -O2 with -O when not needed

Agree. A plan use -O only with gcc2.95.2.

> (ehm, can configure detect and work with this?)

Yes, I'll look configure, it's in may TODO.