nntpext update for -current

[Russ Allbery]

an unspecified meowbot <meowbot at meowing.net> writes:

> An ugly, puke-inducing attempt to keep up with nntpext in -current.

> lib/wildmat.c: Add wildmat_classic, wildmat without the magic comma and
> bang.  This lets XPAT regain its traditional behavior, which seems like
> the right thing to do seeing that PAT is dead.

> nnrpd/article.c: That do{...}while(0); loop is there to make sure Glom()
> garbage gets freed, and returning instead of breaking out of the loop
> kinda defeats it.  [had returns there locally, not sure how I managed to
> mangle the earlier patch.] I'm not touching the Argify/Glom whitespace
> weirdness, it's not helpful to change behavior that's been there
> forever, esp. where nnrpd is the de facto standard for this command.

> nnrpd/nnrpd.c: Lose the PAT command and add HDR.

> nnrpd/commands.c: Replace the PAT extension with HDR.  The current draft
> doesn't fully reflect this change, but the next one will.

> doc/pod/wildmat.pod: Make appropriate disdainful noises about
> wildmat_classic.

This is now in, although I did the wildmat change in a different way.
There's no need to call match_expression at all from wildmat_simple since
match_expression exists solely to do the ! and , handling, and as a rule
of thumb I try to avoid "dated" names for interfaces like wildmat_classic,
because what it's classic relative to is often rather mysterious ten years
later.

I also added tests for the new wildmat interface and rechecked coverage
with purecov.

Thank you very much!

-- 
Russ Allbery (rra at stanford.edu)             <http://www.eyrie.org/~eagle/>