patches to fix bindaddress (for IPv6) in innfeed

Jeffrey M. Vinocur jeff at litech.org
Thu Mar 28 05:53:34 UTC 2002



On Wed, 27 Mar 2002, Antonio Querubin wrote:

> Ok, here's an attempt to add meager documentation for bindaddress6 to the
> manpage for innfeed.  The updated connection.c.diff also removes the
> dependency on the SA_LEN macro which may be causing build problems for
> some.

Thanks, all of this just committed.

I found the bug in the configuration file parser that was causing the
problems you described earlier -- the code was using strncmp to find a
matching parameter, but the n was set to the length of the parameter being
looked up (so if one parameter was a prefix of another, it would appear to
match).  I added a check to make sure the lengths matched before doing the
strncmp.

(This does eliminate a bit of functionality that conceivably somebody
could want, but grepping for findValue and the getString / getInteger /
getBool / getReal wrappers doesn't turn up anything that looks like the
kind of hackery that would use this.)


-- 
Jeffrey M. Vinocur
jeff at litech.org



More information about the inn-patches mailing list