base cygwin patches

Jeffrey M. Vinocur jeff at litech.org
Thu Nov 28 16:53:51 UTC 2002



On Sat, 31 Aug 2002, Russ Allbery wrote:

> greg andruk <gja at meowing.net> writes:
> 
> >  - cygwin's IOV_MAX is 2147483646, which breaks an assumption about
> >    array sizes in nnrpd, so force an arbitrary typical size in
> >    configure.  Rename to INN_IOV_MAX to avoid #undef/#define confusion
> 
> I took another route with this.  The uses in innfeed were safe, so in
> nnrpd where IOV_MAX was used to declare arrays, I just capped it at 1024.

You missed this though:  :-)


--- nnrpd/article.c     2002/09/30 03:27:59     1.124
+++ nnrpd/article.c     2002/11/28 16:51:29
@@ -151,7 +151,7 @@
     }
     iov[queued_iov].iov_base = (char*)p;
     iov[queued_iov++].iov_len = len;
-    if (queued_iov == IOV_MAX)
+    if (queued_iov == sizeof(iov))
         return PushIOv();
     return TRUE;
 }


-- 
Jeffrey M. Vinocur
jeff at litech.org



More information about the inn-patches mailing list