rnews: batch naming and locking

Alex Kiernan alexk at demon.net
Tue Oct 22 09:29:29 UTC 2002



"Miquel van Smoorenburg" <miquels at cistron.nl> writes:

> On one of our servers multiple rnews -U processes were running at
> the same time, and because rnews doesn't lock the batch it's
> processing this resulted in the same posting getting submitted
> to innd multiple times. Innd rejected the duplicates, and they
> ended up in the bad/ directory filling up the disk.
> 
> So I fixed that by making rnews lock the batch using inn_lock_file.
> While editting rnews.c I fixed a few other bugs as well:
> 
> - in main(), if UnpackOne() fails, Spool() is called but we
>   have to rewind the fd first
> - ReadRemainder() closes the file when its done - it should
>   leave that to the caller
> - Unspool() sets UUCPHost unconditionally, it should only
>   do that for batches that have a host in their name
> - In fact, the remote hostname is never encoded in the batch
>   file when spooling it.
> 

Applied - sorry about the delay :(

-- 
Alex Kiernan, Principal Engineer, Development, THUS plc


More information about the inn-patches mailing list