Inncheck

Julien ÉLIE julien at trigofacile.com
Fri Dec 29 18:51:31 UTC 2006


Hi,

When I run Inncheck, I have those errors:

29/12 19:23 news at guepard ~/home/bin% /usr/lib/news/bin/inncheck -f -perms
# /var/lib/news/history:0: mode 664, should be 644
chmod 644 /var/lib/news/history
# /usr/lib/news/bin/sendbatch:0: missing
# /usr/lib/news/bin/rnews.libexec:0: ERROR: illegal file `bunbatch' in directory



As we have:

%modes = (
     'active',		@FILEMODE@,

I think it would be better to have (if possible):

-    &checkperm($paths{'history'}, 0644);
+    &checkperm($paths{'history'}, @FILEMODE@);



And:

@rnews_programs = (
-    'c7unbatch', 'decode', 'encode', 'gunbatch'
+    'bunbatch', 'c7unbatch', 'decode', 'encode', 'gunbatch'
);
@newsbin_public = (
      'archive', 'batcher', 'buffchan', 'convdate', 'cvtbatch', 'expire',
      'filechan', 'getlist', 'grephistory', 'innconfval', 'innxmit',
-    'makehistory', 'nntpget', 'overchan', 'prunehistory', 'shlock',
-    'shrinkfile'
+    'makehistory', 'nntpget', 'overchan', 'prunehistory', 'sendbatch',
+    'shlock', 'shrinkfile'
);


And also:

%newsfeeds'flags = (
      '<',        '^\d+$',
      '>',        '^\d+$',
-    'A',        '^[cCdeoOp]+$',
+    'A',        '^[cCdefoOp]+$',
      'B',        '^\d+(/\d+)?$',
      'C',        '^\d+$',
      'F',        '^.+$',
      'G',        '^\d+$',
      'H',        '^\d+$',
      'I',        '^\d+$',
      'N',        '^[mu]$',
      'O',        '^\S+$',
      'P',        '^\d+$',
      'S',        '^\d+$',
      'T',        '^[cflmpx]$',
+    'U',        '^\d+$',
      'W',        '^[befghmnpst*DGHNPOR]*$',
);


Moreover, there are some weird characters at line 99, 645 and 801.
Could it be possible to delete them?
(and also in all the other files of the svn please)

Regards,

-- 
Julien

« -- Dis Astérix ! Quelle salade pour un peu d'huile !
   -- Oui, et dépêchons-nous de trouver un guérisseur
   avant que ça ne tourne au vinaigre. » (Astérix)



More information about the inn-patches mailing list