Update README contrib

[Julien ÉLIE]

En réponse à Russ Allbery :
> Thanks, applied.  (I'm sorry about how long it's taken me to get to these.
> I hope it won't discourage you from contributing in the future!)

Great!  Thanks.

By the way, I also suggested other patches.
Is something wrong with them?


1/ controlchan.in
-----------------

Whenever a control article is successfully processed, I have :

Error log:
Use of uninitialized value in concatenation (.) or string at /usr/lib/news/bin/controlchan line 315.

     if ($logfile eq 'mail') {
         my $mail = sendmail($message);
         print $mail map { s/^~/~~/; "$_\n" } @$headers;
------> print $mail "$_\n" . join ('', map { s/^~/~~/; "$_\n" } @$body)
             if $body;
         close $mail or logdie("Cannot send mail: $!");
         return;
     }


Shouldn't it be directly :

print $mail join ('', map { s/^~/~~/; "$_\n" } @$body)

It works well.



2/ checkgroups.pl
-----------------

For control/checkgroups.pl:

+    if ($#output > 2) {
      logger($log || 'mail', "checkgroups by $sender", \@output);
+    }

Because it sends mails even though there is nothing.



3/ docheckgroups
----------------

And for docheckgroups (for mmap articles, as it has already been
corrected in controlchan by a previous patch):

- ${SED} -n '/(Moderated)$/s/[    ].*//p' | sort >${T}/$$ng.mod
+ ${SED} -e 's/\r\?$//' | ${SED} -n '/(Moderated)$/s/[    ].*//p' | sort >${T}/$$ng.mod

It now knows which groups are moderated.
Otherwise, docheckgroups does not work well!



4/ innreport
------------

Perhaps the more complex of the patches I sugget here.

We discussed a bit of that in « news.software.nntp »
(Innreport fails to log everything).

I have released a patch which includes the modifications
done in <http://members.ll.net/supraexpress/>.

Here it is: <http://people.via.ecp.fr/~iulius/inn2/innreport/>.

I have successfully tested it (with stable Debian Sarge version of INN 2.4.2).

The patch for version 2.4.2 is « *.diff ».  It has been working well for two
months with my INN2.


Regarding version 2.5, it is « *.CURRENT.diff » since there was a change
in it (rejected_size was added).
It should normally work (according to Frédéric Senault).

Anyway, simply do « scanlogs norotate » and see whether numbers are well displayed :)

-- 
Julien

« On ne va jamais si loin que lorsque l'on ne sait pas où l'on va. »