Mails from controlchan when nothing to do

Julien ÉLIE julien at trigofacile.com
Mon Sep 4 08:38:15 UTC 2006


Hi,

Controlchan currently sends mails when there is no change.  I think
there is no use doing that; it should only send them the first time
an action is taken.
Regarding the Big-Eight for instance, it will send one mail when
there is a newgroup and nothing the other times (the following
day, the following week and the following month). It saves mails
and makes the newsmaster's life easier (less to control).

Furthermore, it is already the behaviour of rmgroup:

} elsif ($action eq 'doit' and $status !~ /(no change|unapproved)/) {



In order to do that:


newgroup.pl
-----------

     } elsif ($action eq 'doit' and $status ne 'unapproved') {
         ctlinnd('newgroup', $groupname, $modcmd, $sender)
             if $status ne 'no change';

[...]

+       if ($log ne 'mail' or $status ne 'no change') {
             logger($log, "newgroup $groupname $modcmd $status $sender",
                 $headers, $body) if $log;
+       }
     }

-- 
Julien

« Un dictionnaire est comme une montre ; il vaut mieux en avoir un
   que pas du tout, mais le meilleur n'est jamais tout à fait exact. »
   (Georges-Bernard Shaw)



More information about the inn-patches mailing list