BUG in art.c:2284 ARTpost() causes core

Miquel van Smoorenburg list-inn-workers at news.cistron.nl
Thu Nov 18 13:38:44 UTC 1999


In article <cistron.19991118061747.62129285BC at wawura.off.connect.com.au>,
Andrew McNamara  <andrewm at connect.com.au> wrote:
>There's a bug in the ARTpost() function - when it sees an article with
>a distribution header such as "Distribution: ," (note the comma), the
>DISTparse() function returns a distribution[] array with a null pointer
>as it's first element (i.e., an empty list). The later call to
>MaxLength() in the arguments to sprintf() dereferences this and dies in
>flames.

Here's a small patch to cleanfeed that works around this problem. This
way you won't have to recompile INN straight away on all you servers.
I've also put this and some more info up on http://www.miquels.cistron.nl/inn/

--- cleanfeed.orig	Thu Sep 23 20:57:16 1999
+++ cleanfeed	Thu Nov 18 14:11:31 1999
@@ -523,6 +523,10 @@
         $timer{'articles'}++;
     }
 
+    if ($hdr{'Distribution'} =~ /(^|,)\s*,\s*(,|$)/) {
+	return reject ("Bogus distribution header with null element", "Bad distribution header");
+    }
+
     if (! $hdr{'Control'}) {
 
 	&trimhashes if ($cycles++ > $config{'trimcycles'});

Mike.
-- 
First things first, but not necessarily in that order.
-- 
The From: and Reply-To: addresses are internal news2mail gateway addresses.
Reply to the list or to miquels at cistron.nl (Miquel van Smoorenburg)


More information about the inn-workers mailing list