BUG in art.c:2284 ARTpost() causes core

Katsuhiro Kondou kondou at nec.co.jp
Fri Nov 19 01:31:01 UTC 1999


In article <19991118230610.3EDEA285C9 at wawura.off.connect.com.au>,
	Andrew McNamara <andrewm at connect.com.au> wrote;

} I tried something like this first up, but the null list comes about as
} a result of DISTparse() cleaning the list. You need to move the call to
} DISTparse() above the check on the first element of the list.

Exactly.  I should have checked the patch more carefully.
I believe attached would fix.  Just committed.

--- innd/art.c.orig	Fri Nov 19 10:21:19 1999
+++ innd/art.c	Fri Nov 19 10:21:52 1999
@@ -2127,7 +2127,7 @@
     p = HDR(_distribution);
     distributions = *p ? CommaSplit(p) : NULL;
     if (distributions) {
-      if (distributions[0] == '\0') {
+      if (*distributions[0] == '\0') {
 	(void)sprintf(buff, "%d bogus distribution \"%s\"",
 		NNTP_REJECTIT_VAL,
 		MaxLength(p, p));


-- 
Katsuhiro Kondou


More information about the inn-workers mailing list