innreport feature request ...

[Fabien Tassin]

According to George Lindholm:
> 
> Fabien Tassin wrote:
> > 
> > According to The Hermit Hacker:
> > >
> > > Applied...doesn't seem to break anything, but it doesn't appar to get
> > > added to the report either?
> > 
> > well.. it should have worked. no time to check now :( sorry.
> > 
> > > Also, would it make sense to change "Newsgroups request counts (by
> > > category)" such that it doesn't print anything if count == 0?  I didn't
> > > think it used to, maybe a bug got introduced?  Nope, just checked
> > > yesterdays, before this recent patch, and it does too...makes for a very
> > > long report when >1000 lines just report 0 :)
> > 
> > hmm.. I've only made a small change for that section :
> > 
> > before:
> >  my ($num) = $text =~ m/foo (\d+) bar/;
> >  if ($num != 0) { ..... }
> > 
> > after:
> >  my ($num) = $text =~ m/foo (\d+) bar/;
> >  if ($num) { ..... }
> > 
> > looks equivalent to me..
> 
> Not quite. The first version sees if $num is numerically not zero,
> while the second version works if $num has any value, not necessarily a
> numeric one.

right and that's why I've quoted the previous line too..
$num contains a \d+ match so I can assume that it is a numeric value or
undef and then, in both cases, the block will be executed appropriatly.
IMHO, the problem is not there :(

-- 
Fabien Tassin -+- fta at oleane.net