LockFile

Russ Allbery rra at stanford.edu
Mon Aug 14 21:02:17 UTC 2000


Heath Kehoe <heath.kehoe at intermec.com> writes:

> Would anyone object if I extend LockFile() to include a type parameter?
> (one of: LOCK_READ, LOCK_WRITE, LOCK_UNLOCK)

> I need shareable-locking in the new version of ovdb that I'm working on.
> I could use LockRange() which also has this parameter, but I don't need
> the range part.

I have no objections.  Would you like to rename it too since you're
changing the interface and we have a good opportunity?  I've been trying
to cut down on the amount of studly-caps function names in INN as a
consistency of style thing (there were examples either way and I just
picked the direction that I personally like better), and I've been
renaming functions when I make major modifications to them.

I'd much rather see lock_file() and lock_range() instead of the current
names.  (No need to rename LockRange right now unless you want to; I can
take care of it later.)

-- 
Russ Allbery (rra at stanford.edu)             <http://www.eyrie.org/~eagle/>



More information about the inn-workers mailing list