Purify errors

[Alex Kiernan]

With apologies for the length... looks like theres a few interesting
ones shown up overnight (trimmed to just those):

****  Purify instrumented /news/bin/innd (pid 25507, forked from pid 25498)  ****
ABR: Array bounds read:
  * This is occurring while in:
	strlen         [rtlib.o]
	x_strdup       [xmalloc.c:116]
	ARTcontrol     [art.c:1291]
	ARTpost        [art.c:2677]
	NCpostit       [nc.c:194]
	NCproc         [nc.c:972]
  * Reading 913 bytes from 0x779428 in the heap (1 byte at 0x7797b8 illegal).
  * Address 0x779428 is 3184 bytes into a malloc'd block at 0x7787b8 of 4096 bytes.
  * This block was allocated from:
	malloc         [rtlib.o]
	realloc        [rtlib.o]
	x_realloc      [xmalloc.c:102]
	CHANreadloop   [chan.c:1093]
	main           [innd.c:637]
	_start         [crt1.o]

****  Purify instrumented /news/bin/innd (pid 25507, forked from pid 25498)  ****
ABR: Array bounds read:
  * This is occurring while in:
	memcpy         [rtlib.o]
	x_strdup       [xmalloc.c:122]
	ARTcontrol     [art.c:1291]
	ARTpost        [art.c:2677]
	NCpostit       [nc.c:194]
	NCproc         [nc.c:972]
  * Reading 913 bytes from 0x779428 in the heap (1 byte at 0x7797b8 illegal).
  * Address 0x779428 is 3184 bytes into a malloc'd block at 0x7787b8 of 4096 bytes.
  * This block was allocated from:
	malloc         [rtlib.o]
	realloc        [rtlib.o]
	x_realloc      [xmalloc.c:102]
	CHANreadloop   [chan.c:1093]
	main           [innd.c:637]
	_start         [crt1.o]

****  Purify instrumented /news/bin/innd (pid 25507, forked from pid 25498)  ****
UMR: Uninitialized memory read:
  * This is occurring while in:
	strlen         [rtlib.o]
	HeaderCleanFrom [cleanfrom.c:26]
	ARTcontrol     [art.c:1302]
	ARTpost        [art.c:2677]
	NCpostit       [nc.c:194]
	NCproc         [nc.c:972]
  * Reading 913 bytes from 0x6cf6b0 in the heap (1 byte at 0x6cfa40 uninit).
  * Address 0x6cf6b0 is at the beginning of a malloc'd block of 913 bytes.
  * This block was allocated from:
	malloc         [rtlib.o]
	x_strdup       [xmalloc.c:117]
	ARTcontrol     [art.c:1291]
	ARTpost        [art.c:2677]
	NCpostit       [nc.c:194]
	NCproc         [nc.c:972]

****  Purify instrumented /news/bin/innd (pid 25507, forked from pid 25498)  ****
Purify: Searching for new memory leaks since last purify_new_leaks() call...

New memory leaked: 894227 bytes (7.2%); potentially leaked: 91178 bytes (0.734%)

MLK: 563475 bytes leaked in 275 blocks
  * This memory was allocated from:
	malloc         [rtlib.o]
	x_malloc       [xmalloc.c:74]
	ARTassignnumbers [art.c:1442]
	ARTpost        [art.c:2558]
	NCpostit       [nc.c:194]
	NCproc         [nc.c:972]
  * Block of 2049 bytes (275 times); last block at 0x1a3fb60

MLK: 236544 bytes leaked in 231 blocks
  * This memory was allocated from:
	malloc         [rtlib.o]
	x_malloc       [xmalloc.c:74]
	ARTmakeoverview [art.c:1996]
	ARTpost        [art.c:2587]
	NCpostit       [nc.c:194]
	NCproc         [nc.c:972]
  * Block of 1024 bytes (231 times); last block at 0x1a3f540

MLK: 92160 bytes leaked in 45 blocks
  * This memory was allocated from:
	malloc         [rtlib.o]
	realloc        [rtlib.o]
	x_realloc      [xmalloc.c:102]
	ARTmakeoverview [art.c:2048]
	ARTpost        [art.c:2587]
	NCpostit       [nc.c:194]
  * Block of 2048 bytes (45 times); last block at 0x1a3d140

MLK: 2048 bytes leaked at 0xd80410
  * This memory was allocated from:
	malloc         [rtlib.o]
	realloc        [rtlib.o]
	x_realloc      [xmalloc.c:102]
	BUFFappend     [chan.c:74]
	ARTmakeoverview [art.c:2043]
	ARTpost        [art.c:2587]

PLK: 53274 bytes potentially leaked in 26 blocks
  * This memory was allocated from:
	malloc         [rtlib.o]
	x_malloc       [xmalloc.c:74]
	ARTassignnumbers [art.c:1442]
	ARTpost        [art.c:2558]
	NCpostit       [nc.c:194]
	NCproc         [nc.c:972]
  * Block of 2049 bytes (26 times); last block at 0x18afa88

PLK: 17408 bytes potentially leaked in 17 blocks
  * This memory was allocated from:
	malloc         [rtlib.o]
	x_malloc       [xmalloc.c:74]
	ARTmakeoverview [art.c:1996]
	ARTpost        [art.c:2587]
	NCpostit       [nc.c:194]
	NCproc         [nc.c:972]
  * Block of 1024 bytes (17 times); last block at 0x15e17b0

PLK: 12288 bytes potentially leaked in 6 blocks
  * This memory was allocated from:
	malloc         [rtlib.o]
	realloc        [rtlib.o]
	x_realloc      [xmalloc.c:102]
	ARTmakeoverview [art.c:2048]
	ARTpost        [art.c:2587]
	NCpostit       [nc.c:194]
  * Block of 2048 bytes (6 times); last block at 0x166f970

PLK: 4104 bytes potentially leaked at 0x7cb898
  * This memory was allocated from:
	malloc         [rtlib.o]
	setvbuf        [libc.so.1]
	ReopenLog      [innd.c:260]
	CCflushlogs    [cc.c:712]
	CCreader       [cc.c:1868]
	CHANreadloop   [chan.c:1023]

PLK: 4104 bytes potentially leaked at 0x6f9700
  * This memory was allocated from:
	malloc         [rtlib.o]
	setvbuf        [libc.so.1]
	ReopenLog      [innd.c:260]
	CCflushlogs    [cc.c:711]
	CCreader       [cc.c:1868]
	CHANreadloop   [chan.c:1023]

Purify Heap Analysis (combining suppressed and unsuppressed blocks)
                         Blocks        Bytes
              Leaked        654      1061189
  Potentially Leaked         61       121919
              In-Use     116257     11233297
  ----------------------------------------
     Total Allocated     116972     12416405

-- 
Alex Kiernan, Principal Engineer, Development, Thus PLC