Memory leaks

Alex Kiernan alexk at demon.net
Wed Jul 4 09:06:46 UTC 2001


Russ Allbery <rra at stanford.edu> writes:

> Alex Kiernan <alexk at demon.net> writes:
> 
> > Woohoo, Purify's not confused, I've found it (I think)... does this
> > patch look reasonable to everyone:
> 
> Um, yup.  Looks right to me.  Aie.  I'll commit this tomorrow if no one
> objects.  It looks like this only applies to CURRENT because STABLE
> doesn't include an ARTDATA in a CHANNEL.
> 

Just noticed a typo...

> > Index: chan.c
> > ===================================================================
> > RCS file: /upstream-repositories/inn-cvs.isc.org/inn/innd/chan.c,v
> > retrieving revision 1.54
> > diff -c -r1.54 chan.c
> > *** chan.c	2001/05/14 04:05:33	1.54
> > --- chan.c	2001/07/04 08:08:39
> > ***************
> > *** 343,348 ****
> > --- 343,358 ----
> >   		DISPOSE(cp->Data.Path.List);
> >   		cp->Data.Path.List = NULL;
> >   	    }
> > + 	    if (cp->Data.Overview.Size != 0) {
> > + 		DISPOSE(cp->Data.Overview.Data);
> > + 		cp->Data.Overview.Data = NULL;
> > + 		cp->Data.Overview.Size = 0;
> > + 	    }
> > + 	    if (cp->Data.XrefBufLength != NULL) {
                                          ^^^^

should be 0.

> > + 		DISPOSE(cp->Data.Xref);
> > + 		cp->Data.Xref = NULL;
> > + 		cp->Data.XrefBufLength = 0;
> > + 	    }
> >   	} else if (cp->Type == CTreject)
> >   	    syslog(L_NOTICE, "%s %ld", name, cp->Rejected);
> >   	else if (cp->Out.Left)
> 

-- 
Alex Kiernan, Principal Engineer, Development, Thus PLC


More information about the inn-workers mailing list