working my way through the docs: perl_access woes

Alex Kiernan alexk at demon.net
Thu Aug 15 08:07:07 UTC 2002


Erik Klavon <erik at eriq.org> writes:

> Hi Matt
> 
> On Wed, Aug 14, 2002 at 07:20:56PM +0100, Matt 'Goo Goo Dolls' Melton wrote:
> > My syslog is merely:
> > Aug 14 18:49:11 myhost nnrpd[30279]: hopeless.client.com (10.0.0.1)
> > connect
> > Aug 14 18:49:41 myhost nnrpd[30279]: SERVER perl filtering enabled
> > 
> > ... With no further notices.
> 
> The problem I found isn't due to your script or readers.conf. Rather,
> its a bug in a modification made by me to conffile.c. Here is a patch:
> 
> diff -ur inn/lib/conffile.c inn_patch/lib/conffile.c
> --- inn/lib/conffile.c  Wed Jun 19 21:49:24 2002
> +++ inn_patch/lib/conffile.c    Wed Aug 14 14:01:44 2002
> @@ -12,11 +12,11 @@
>  static int getconfline(CONFFILE *F, char *buffer, int length) {
>    if (F->f) {
>      fgets(buffer, length, F->f);
> +    if (ferror(F->f)) {
> +      return 1;
> +    }
>    } else if (F->array) {
>      strncpy(buffer, F->array[F->lineno], length);
> -  }
> -  if (ferror(F->f)) {
> -    return 1;
>    }
>    F->lineno++;
>    if (strlen (F->buf) == F->sbuf) {
> 
> Applying that patch to CURRENT solved the problem for me. Let me know
> if it works on your end.
> 

Sorry, I think that was my fault :(

Fix committed earlier this morning.

-- 
Alex Kiernan, Principal Engineer, Development, THUS plc


More information about the inn-workers mailing list