Problems post sprintf->snprintf conversion

[Alex Kiernan]

Russ Allbery <rra at stanford.edu> writes:

> Kiernan, Alex <alexk at demon.net> writes:
> 
> > Anyone seeing anything like this in there logs (Solaris 8):
> 
> > "Aug 19 00:38:01 mutlu.news.demon.net innd: [ID 903239 news.warning]
> > kibo.news.demon.net:76 closed seconds 3845 accepted 7769 refused 0 rejected
> > 57 duplicate 53 accepted size "
> 
> > Where the accepted size (and all the following fields) are missing?
> 
> > I've looked at the change and it looks entirely reasonable. 
> 
> Haven't updated to the new innd yet; I'm hoping to do that this week.  I
> checked those changes by inspection, I fear, rather than extensive running
> of the code.
> 
> That's a really weird place for it to break the line.  It's 14 characters
> in, so it shouldn't be a sizeof problem.  If you're on Solaris 8, you'll
> be using the version that comes with INN; if you run make test, does it
> pass all its tests?  One of them does test %.0f formats, which are being
> used here.
> 

Yup, the tests succeed (I've only one problem with the tests which I
must dig into some time - vector-t.c fails 55 and 64 when you turn up
optimisation on Forte C 6.2).

I'll try to add in some debugging to get to the bottom of it.

-- 
Alex Kiernan, Principal Engineer, Development, THUS plc