controlchan bug
Russ Allbery
rra at stanford.edu
Tue Dec 31 19:13:53 UTC 2002
Kai Henningsen <kaih at khms.westfalen.de> writes:
> rra at stanford.edu (Russ Allbery) wrote:
>> Marco d'Itri <md at Linux.IT> writes:
>> > logdie('Cannot run docheckgroups: ' . $!) if $st == -1;
>> > logdie('docheckgroups returned status ' . ($st & 255)) if $st > 0;
>> > + close STDOUT;
>> > open(STDIN, '<&OLDIN') or die $!;
>> > open(STDOUT, '>&OLDOUT') or die $!;
>>
>> Thanks, applied.
> Dumb question: shouldn't Perl do that all by its lonesome, two lines
> later?
Yeah, it should. Marco, did this patch make a difference in testing?
I still want it in anyway, since it's cleaner and more obvious to
explicitly close, I think.
--
Russ Allbery (rra at stanford.edu) <http://www.eyrie.org/~eagle/>
Please send questions to the list rather than mailing me directly.
<http://www.eyrie.org/~eagle/faqs/questions.html> explains why.
More information about the inn-workers
mailing list