cant cancel Issues

Katsuhiro Kondou Katsuhiro_Kondou at isc.org
Wed Feb 6 01:22:22 UTC 2002


In article <Pine.LNX.4.33.0202051836570.12161-100000 at marduk.litech.org>,
	"Jeffrey M. Vinocur" <jeff at litech.org> wrote;

} and it logs like this:
} 
}     Feb  5 18:05:04 marduk innd: SERVER cant cancel
}     @05000000037D000067340000000000000000@ (SMerrno 0)
} 
} So then SMcancel is returning zero, of course.

Ok.  I think some of links are already unlinked, and the
article is crossposted.  In the case, unlink() fails and
the return value is set to zero.  I believe this is a bug,
and this should be gone by ignoring return value of
unlink() at unlinking the link.
-- 
Katsuhiro Kondou

--- tradspool.c.orig	Fri Jan  4 07:39:44 2002
+++ tradspool.c	Wed Feb  6 10:18:59 2002
@@ -960,8 +960,8 @@
 
 	linkpath = NEW(char, strlen(innconf->patharticles) + strlen(ng) + 32);
 	sprintf(linkpath, "%s/%s/%lu", innconf->patharticles, ng, artnum);
-	/* hmm, do we want to abort this if one of the symlink unlinks fails? */
-	if (unlink(linkpath) < 0) result = FALSE;
+	/* some of links may be gone already, and we don't care the return value*/
+	(void)unlink(linkpath);
 	DISPOSE(linkpath);
     }
     if (unlink(path) < 0) result = FALSE;


More information about the inn-workers mailing list