nnpd bug

[Russ Allbery]

Katsuhiro Kondou <Katsuhiro_Kondou at isc.org> writes:
> "souadh at libertysurf.fr" <souadh at libertysurf.fr> wrote;

> } it seems not to work for me ,I'm using inn 2.3.2
> } Is it a bug ??

> I think it should be a bug.

> } If not How it is possible to enable listgroup command to 
> } get the listing of the current group if the parameter 
> } group is not specify 

> Try attached which works for me.

I think that will make GROUP with no arguments work, which while not a
serious error, is supposed to be signaled as invalid syntax according to
the RFC.  (The group is listed as a required parameter in RFC 977 and in
the new NNTP draft.)

doc/compliance-nntp has this to say:

  Summary: nnrpd doesn't handle zero-argument LISTGROUP
 Standard: draft-ietf-nntpext-base-13.txt, section 9.5.1.1
  Version: 2.3 to CURRENT 2001-07-04
Reference: nnrpd/group.c CMDgroup()
 Severity: Violates a MUST

The standard says:

    The LISTGROUP command is used to get a listing of all the article
    numbers in a particular newsgroup.  The optional parameter ggg is the
    name of the newsgroup to be selected (e.g. "news.software.b").  A list
    of valid newsgroups may be obtained from the LIST command.  If no
    group is specified, the current group is used as the default argument.

nnrpd currently rejects LISTGROUP commands that don't specify a group,
however (and with an error code of 481, which isn't one of the specified
return codes for LISTGROUP).

Impact:  A client that attempts to use LISTGROUP to list the valid
articles in the current newsgroup will fail and get back a confusing error
code.

Suggested fix:  Add this functionality to the LISTGROUP implementation.
It may be best (and will likely be cleaner) to split LISTGROUP out of the
handler for GROUP into its own function.

-- 
Russ Allbery (rra at stanford.edu)             <http://www.eyrie.org/~eagle/>