small optimization for history writes

Alex Kiernan alexk at demon.net
Fri Jan 4 09:08:10 UTC 2002


davidsen at tmr.com (bill davidsen) writes:

> In article <9u8co5$3d3$1 at ncc1701.cistron.net>,
> Miquel van Smoorenburg <list-inn-workers at news.cistron.nl> wrote:
> 
> | No but I wasn't sure this was quite right so I posted it here instead
> | of in -patches, seems like that was a good idea.
> | 
> | Now there are two ways to fix it, either by keeping an offset
> | variable in struct hisv6, or by fixing glibc .. I'll have to
> | think about that.
> 
>   As a general question, since most of INN uses mmap virtually
> everywhere, why is this code not doing so?

Because it grows files, rather than relying on statically sized ones.

It even relies on the buffering in stdio in some instances (during
expires); frankly its all a bit horrid...

-- 
Alex Kiernan, Principal Engineer, Development, Thus PLC


More information about the inn-workers mailing list