[glynis at butterfly.hjsoft.com: Bug#180462: inn2: segfault in news.daily script and other oddities]
rra at stanford.edu
Sat Feb 15 20:35:31 UTC 2003
Marco d'Itri <md at Linux.IT> writes:
> On Feb 12, Marco d'Itri <md at Linux.IT> wrote:
>> I noticed that expireover dies on my system too (running CURRENT-20030205).
> Stack trace:
I think this all comes from the memory clobber here scribbling all over
heap. This is, at least, a correct change that should fix it to some
--- inn/storage/expire.c 2003/01/19 22:56:34 1.14
+++ inn/storage/expire.c 2003/02/15 20:33:19
@@ -198,7 +198,7 @@ BuildGroups(char *active)
for (p = active, i = 0; (p = strchr(p, '\n')) != NULL; p++, i++)
nGroups = i;
- Groups = xmalloc(sizeof(NEWSGROUP));
+ Groups = xmalloc(i * sizeof(NEWSGROUP));
/* Set up the default hash buckets. */
NGHbuckets = i / NGH_SIZE;
Committed to CURRENT.
Russ Allbery (rra at stanford.edu) <http://www.eyrie.org/~eagle/>
Please send questions to the list rather than mailing me directly.
<http://www.eyrie.org/~eagle/faqs/questions.html> explains why.
More information about the inn-workers