nnrpd issue

Alex Kiernan alexk at demon.net
Tue Jan 21 08:37:15 UTC 2003


Russ Allbery <rra at stanford.edu> writes:

> Pavel V Knyazev <pasha at surnet.ru> writes:
> 
> > Sorry for not anwering to this sooner.
> 
> > Well, i hope i've found that place where it slows down.
> 
> > Must be, it's right here:
> 
> > 8:02pm image:nnrpd> grep -A7 "ARTopen(ARTnumber)" article.c
> >     while (!ARTopen(ARTnumber)) {
> >         ARTnumber += delta;
> >         if (ARTnumber < ARTlow || ARTnumber > ARThigh) {
> >             Reply("%d No %s article to retrieve.\r\n", errcode, message);
> >             ARTnumber = save;
> >             return;
> >         }
> >     }
> > 8:02pm image:nnrpd>
> 
> Well, that's just the main loop of NEXT.
> 
> If the problem is with the storage API calls, Katsuhiro's patch should
> have helped.  So I'm not sure what's going on.
> 

I had a quick look at this - Katsuhiro's patch left in the loop trying
to ARTopen after doing the overview scan, so you'd get the same
behaviour as before (i.e. the slow scan). Dropping in an if () {...} 
else {...} somewhere should help I think.

-- 
Alex Kiernan, Principal Engineer, Development, THUS plc


More information about the inn-workers mailing list