CNFS offset problems

[Dave Williams]

Russ Allbery <rra at stanford.edu> wrote:
> 
> If off_t and size_t are both the same size (32 bits or 64 bits), then the
> signed type (off_t) is promoted to unsigned to match, and the negative
> value on the right hand side becomes a large positive number, thus making
> INN think there's room left in the cycbuff.
> 
> Bleh.
> 
> I'm committing a patch now.  This is why those "comparison between signed
> and unsigned" warnings are important.
> 
> Hopefully I'll have a chance to clean up the CNFS code in INN 2.5.
 
Just to yell out, I'm still seeing this behaviour - a whole bunch of
invalid offsets logged for about 1am today and growing CNFS cycbuffs...

[I'm not using SEQUENTIAL, the cycbuffs /were/ 2Gb a piece, largefile
support is compiled in, code as cvsupd friday morning...]

Dave
-- 
Dave Williams
dave at clues.com