makehistory -a

[Russ Allbery]

Jeffrey M Vinocur <jeff at litech.org> writes:

> I tried `makehistory -a` in CURRENT, and it didn't appear to work (that 
> is, it looks like we started rebuilding into a fresh history file).  A 
> quick look at the source reveals:

>         int flags = HIS_RDWR | HIS_CREAT | HIS_INCORE;

>         if (!AppendMode)
>             flags |= HIS_CREAT;

> and while I don't know exactly what the semantics of HISopen() are 
> supposed to be, I think there must be a bug above.  Perhaps HIS_CREAT 
> shouldn't be in the initial flags= line?

Yup.  Committed.

-- 
Russ Allbery (rra at stanford.edu)             <http://www.eyrie.org/~eagle/>

    Please send questions to the list rather than mailing me directly.
     <http://www.eyrie.org/~eagle/faqs/questions.html> explains why.