References/XOVER bug?

Russ Allbery rra at stanford.edu
Fri Jun 11 05:13:51 UTC 2004


Jeffrey M Vinocur <jeff at litech.org> writes:

> Since upgrading to CURRENT, some articles weren't threading properly.
> It looks like References wasn't included in overview for some reason.

Got it.  It would have only affected headers that were spread across an
even number of lines.  The problem was that ARTcheckheader was being
called at the end of each line of a header rather than only at the
absolute end of the header.  The first time, Length is -1 so it's set to
the length of the header at that point.  The second time, it thinks it's a
duplicate and sets the Length back to -1.  The third time, it thinks it
hasn't seen the header before and sets it back to the real length.  And so
forth.

(Which means that our duplicate detection code may be broken too, as I
think that if a header is repeated three times, it won't look like a
duplicate.  I'll take a look at that.)

-- 
Russ Allbery (rra at stanford.edu)             <http://www.eyrie.org/~eagle/>

    Please send questions to the list rather than mailing me directly.
     <http://www.eyrie.org/~eagle/faqs/questions.html> explains why.


More information about the inn-workers mailing list