enhance checkgroups handling

Julien ÉLIE julien at trigofacile.com
Sun Aug 5 16:03:34 UTC 2007


> Date: Sunday, August 5, 2007 @ 06:39:50
> Author: iulius
> Revision: 7632
>
> Modified: modules/checkgroups.pl
> ===================================================================
> @@ -75,7 +76,12 @@
> -    logger($log || 'mail', "checkgroups by $sender", \@output);
> +    # There is no need to send an empty mail.
> +    if ($#output > 0) {
> +        logger($log || 'mail', "checkgroups by $sender", \@output);
> +    } else {
> +        logmsg("checkgroups by $sender processed (no change)");
> +    }

Perhaps the else {} is useless.  It is just to say that the checkgroups
was processed but we can also see that with the controlchan initial log.


I believe newgroup/rmgroup handling is now optimal.  However, checkgroups
can be improved.
I suggest that the actions be really taken when there are changes (newgroup
and rmgroup) for PGP-signed control articles (with verify-*).  And to also
change the descriptions in the newsgroups file.

I do not know whether it should also be done for a mere doit (without PGP).
Normally, it should not harm since people ask a "doit".  Any thought about that?

-- 
Julien ÉLIE

« Avec des si on mettrait Paris en bouteille. » 



More information about the inn-workers mailing list