inn.conf: Support for `newsuser', `newsgrp' options (patch is, hopefully, included)
Ivan Shmakov
oneingray at gmail.com
Fri Dec 21 15:37:17 UTC 2007
>>>>> Julien ÉLIE <julien at trigofacile.com> writes:
>> --- inn2-2.4.3+20070806-debian-1/samples/inn.conf.in 2007-08-06 16:07:29.000000000 +0700
>> +++ inn2-2.4.3+20070806-debian-1-newsuser/samples/inn.conf.in 2007-12-16 15:32:52.000000000 +0600
>> @@ -24,6 +24,9 @@
>> pathhost: @HOSTNAME@
>> pathnews: @prefix@
>>
>> +newsuser: @NEWSUSER@
>> +newsgrp: @NEWSGRP@
>> +
>> # General Settings
> For inn.conf, is it better to have those two new variables mandatory
> or optional (and set by innconf when it parses the file and does not
> find them)?
To my mind, the only consequence of having these options
mandatory is broken compatibility. So, I believe these should
be left optional.
Doesn't the following bit specify the defaults for them?
diff -drHu inn2-2.4.3+20070806-debian-1/lib/innconf.c inn2-2.4.3+20070806-debian-1-newsuser/lib/innconf.c
--- inn2-2.4.3+20070806-debian-1/lib/innconf.c 2007-08-06 16:07:29.000000000 +0700
+++ inn2-2.4.3+20070806-debian-1-newsuser/lib/innconf.c 2007-12-11 22:33:17.000000000 +0600
@@ -121,6 +121,9 @@
{ K(sourceaddress6), STRING (NULL) },
{ K(timer), NUMBER (0) },
+ { K(newsuser), STRING (NEWSUSER) },
+ { K(newsgrp), STRING (NEWSGRP) },
+
{ K(patharchive), STRING (NULL) },
{ K(patharticles), STRING (NULL) },
{ K(pathbin), STRING (NULL) },
More information about the inn-workers
mailing list