INN and DB 4.5

[Toon van der Pas]

On Fri, May 04, 2007 at 06:28:04PM -0600, The Doctor wrote:
> On Fri, May 04, 2007 at 05:47:10PM -0600, The Doctor wrote:
> > On Fri, May 04, 2007 at 04:26:59PM -0700, Russ Allbery wrote:
> > > The Doctor <doctor at doctor.nl2k.ab.ca> writes:
> > > 
> > > > Just tested out 4.5.20 with OVDB and only one tweak is needed.
> > > > IS anyone interested?
> > > 
> > > Yes.  I don't have a lot of time, but I'm definitely interested.
> > >
> > 
> > Russ you are going to have to change storage/ovdb/ovdb.c
> > 
> > in this convulted way:
> > 
> > I believe you need to change line 1529 so that 
> > 
> > OVDBenv->set_lk_max(OVDBenv, ovdb_conf.maxlocks);
> > 
> > Should change to
> > 
> > #if DB_VERSION_MAJOR == 5 && DB_VERSION_MINOR ==5
>                                ^^^^^^^^^^^^^^^^^^^^
> 
> This should be DB_VERSION_MINOR == 4
> > 	OVDBenv->set_lk_max_locks(OVDBenv, ovdb_conf.maxlocks);
> > #else
> > 	OVDBenv->set_lk_max(OVDBenv, ovdb_conf.maxlocks);
> > #endif

Hi Doctor,

Excuse my ignorance. Are you sure it is correct now?

1. This patch is about db-4.5 right?
   Shouldn't the check then be the other way 'round, like this?

   #if DB_VERSION_MAJOR == 4 && DB_VERSION_MINOR == 5

2. This check matches only ONE specific version.
   What happens when DB is upgraded one minor version?

Regards,
Toon (happy to see that there are still people active on this list)
-- 
"I never set out to be weird,
 it was always other people who called me weird."
                                        -- 1986 Frank Zappa