PATCH: innd: pathcluster
"Miquel van Smoorenburg"
list-inn-workers at news.cistron.nl
Wed Apr 9 16:36:25 UTC 2008
In article <49FC254748594F28A01996052D498E4D at Iulius>,
Julien ÉLIE <julien at trigofacile.com> wrote:
>Thanks a lot for your patch.
>> - if (strncmp(Path.data, hops, Path.used - 1) == 0)
>> + i = strlen(hops);
>> + if (i == Path.used - 1 &&
>> + strncmp(Path.data, hops, Path.used - 1) == 0)
>> data->Hassamepath = true;
> if (i == (signed int) Path.used - 1 &&
> strncmp(Path.data, hops, Path.used - 1) == 0)
>Do you agree or is there a better way to cast that?
Yes, I re-used 'int i' because it was there. If you want to
avoid warnings because i is signed and strlen() and Path.used
are unsigned (size_t really), it would probably be better
to the variable declarations at the top of ARTpost() and just
use n instead of i.
The From: and Reply-To: addresses are internal news2mail gateway addresses.
Reply to the list or to "Miquel van Smoorenburg" <miquels at cistron.nl>
More information about the inn-workers