innfeed, bindaddress, force-ipv4, ipv6

"Miquel van Smoorenburg" list-inn-workers at news.cistron.nl
Thu Apr 17 20:50:07 UTC 2008


In article <D6ACDD92AF304A7E91A76D8BFF24D031 at Iulius>,
Julien ÉLIE  <julien at trigofacile.com> wrote:
>Hi Miquel,
>
>Thanks a lot for your patch.
>
>> --- ../orig/inn-STABLE-20080414/innfeed/connection.c 2008-04-14
>11:08:15.000000000 +0200
>> +++ inn-STABLE-20080414/innfeed/connection.c 2008-04-15
>13:15:38.000000000 +0200
>
>I added:
>
>-      memcpy( &cxnSelf, bind_addr, sizeof(struct sockaddr_in) );
>+      memcpy( (struct sockaddr_storage *)&cxnSelf, bind_addr,
>
>Is it a cast to (struct sockaddr_storage *) and not (struct
>sockaddr_in/in6 *) or
>(struct sockaddr *) which should be done?
>--> const struct sockaddr_storage cxnAddr, cxnSelf ;

Doesn't really matter - it looks like you're using the cast to
make the implicit (const <type> *) to (<type> *) conversion explicit,
you might as well use (void *) in the case of memcpy since that's
memcpy's prototype.

>> --- ../orig/inn-STABLE-20080414/innfeed/host.c 2008-04-14
>11:08:15.000000000 +0200
>> +++ inn-STABLE-20080414/innfeed/host.c 2008-04-17 18:57:48.000000000 +0200
>> +      if ( strcmp(q, "any") != 0 && strcmp(q, "all") != 0 != 0 &&
>> +    strcmp(q, "none") != 0)
>
>Only one "!= 0" here.

Good catch! Heh, a typo that is conceptually and syntactically
correct, that's pretty cool, really.

I'll work on a 2.5 version soon.

Mike.
-- 
The From: and Reply-To: addresses are internal news2mail gateway addresses.
Reply to the list or to "Miquel van Smoorenburg" <miquels at cistron.nl>


More information about the inn-workers mailing list