Failure in inn-CURRENT-20081115

[F. Senault]

Friday, November 21, 2008, 11:31:07 AM, I wrote:

> Thursday, November 20, 2008, 10:42:15 PM, you wrote:

>> Is there something that does not work on your INN?  (let alone the test suite)

> BTW, I've been trying one of the latest snapshots (CURRENT-20081118),
> and it works fairly well - great work !

Ah, finally, a little problem...

My news client has a feature that allows to download one article by
its message-ID if it doesn't find it in its local datable.  Il the
connection is closed, the sequence is simply authinfo then article.

With the latest snapshot, you can't get an article by its message-ID
unless you've sent one group command.  The faulty line seems to be :

--- official/nnrpd/article.c Fri Dec  5 11:01:14 2008
+++ local/nnrpd/article.c    Fri Dec  5 23:15:21 2008
@@ -632,7 +632,7 @@
     }

     /* Check authorizations. */
-    if (!ok || PERMgroupmadeinvalid) {
+    if (!ok) {
        Reply("%d Read access denied\r\n",
               PERMcanauthenticate ? NNTP_FAIL_AUTH_NEEDED : NNTP_ERR_ACCESS);
        return;

Now, I don't know the exact implications of this patch... but it works
around this small glitch.

Fred
-- 
And the Prime Directive would be a valid excuse to do absolutely nothing
all day.  "I can't fix $LUSER's problem, because to do so would
interfere with their development/evolution.  Sorry."
                                             (James Turinsky in the SDM)