strftime for innfeed

Julien ÉLIE julien at trigofacile.com
Sun Dec 21 12:02:01 UTC 2008


Hi Alexander,

> With the one exception of function error_log_stderr_date (in misc.c)
> innfeed currently uses ctime(3) to print date and time. I changed
> that all to strftime(3) and made the format string configurable.

Thanks.  Just committed.
Saved as ticket #97.

I have also updated samples/innfeed.conf.



> Index: innfeed/endpoint.c
> ===================================================================
> --- innfeed/endpoint.c (revision 8218)
> +++ innfeed/endpoint.c (working copy)

At line 1631, there is still:

    t = theTime() ;
    d_printf (1,"Time now is %s",ctime(&t)) ;

Shouldn't it be switched to strftime too?



> +.B log-time-format
> +This key requires a format string suitable for strftime(3). It is used for
> +messages sent via syslog(3) and to the \fBstatus-file\fP.

Also to syslog?  Then it is what is written for instance in news.notice but
it does not follow the specified format, does it?  (hard-coded "%b %d %H:%M:%S"
without the leading day name and the trailing year in innfeed/misc.c?)

-- 
Julien ÉLIE

« Et s'il n'en reste qu'un, je serai celui-là ! » (Victor Hugo) 




More information about the inn-workers mailing list